Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: UI can create credentials with refresh service field #604

Merged
merged 25 commits into from
Jan 25, 2024
Merged

feat: UI can create credentials with refresh service field #604

merged 25 commits into from
Jan 25, 2024

Conversation

x1m3
Copy link
Contributor

@x1m3 x1m3 commented Jan 18, 2024 •
edited
Loading

Changes in Create/Show Credential interface:

  • There is a new field refresh service to be included in the credential. This field needs the credential to have an expiration date.
  • Credential expiration time becomes a time. Not only a date. This is useful for credentials with short live time.

@x1m3 x1m3 added the frontend label Jan 18, 2024
@x1m3 x1m3 self-assigned this Jan 18, 2024
@x1m3 x1m3 requested review from a team as code owners January 18, 2024 16:09
@x1m3 x1m3 changed the base branch from main to develop January 18, 2024 16:09
@x1m3 x1m3 marked this pull request as draft January 18, 2024 16:51
@x1m3 x1m3 added the do not merge Please, do not merge it. label Jan 18, 2024
@x1m3 x1m3 removed the do not merge Please, do not merge it. label Jan 19, 2024
@x1m3 x1m3 marked this pull request as ready for review January 19, 2024 09:01
@x1m3 x1m3 marked this pull request as draft January 22, 2024 12:16
@x1m3 x1m3 marked this pull request as ready for review January 22, 2024 17:48
amonsosanz
amonsosanz reviewed Jan 23, 2024
View reviewed changes
ui/src/domain/credential.ts Outdated Show resolved Hide resolved
ui/src/components/credentials/IssueCredentialForm.tsx Outdated Show resolved Hide resolved
ui/src/components/credentials/IssueCredentialForm.tsx Show resolved Hide resolved
ui/src/adapters/api/credentials.ts Outdated Show resolved Hide resolved
ui/src/adapters/api/credentials.ts Outdated Show resolved Hide resolved
ui/src/adapters/parsers/forms.ts Outdated Show resolved Hide resolved
ui/src/adapters/parsers/forms.ts Outdated Show resolved Hide resolved
ui/src/adapters/parsers/forms.ts Outdated Show resolved Hide resolved
ui/src/components/credentials/CredentialDetails.tsx Outdated Show resolved Hide resolved
ui/src/components/credentials/IssueCredential.tsx Show resolved Hide resolved
@x1m3 x1m3 requested a review from mabaro3009 January 24, 2024 16:55
@x1m3 x1m3 merged commit 6ebd92c into develop Jan 25, 2024
3 checks passed
@x1m3 x1m3 deleted the PID-1651-support-refresh-service-on-frontend branch January 25, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amonsosanz amonsosanz amonsosanz approved these changes

@elias-garcia elias-garcia Awaiting requested review from elias-garcia

@martinsaporiti martinsaporiti Awaiting requested review from martinsaporiti

@javip97 javip97 Awaiting requested review from javip97

@mabaro3009 mabaro3009 Awaiting requested review from mabaro3009

Assignees

@x1m3 x1m3

Labels
frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@x1m3 @amonsosanz @mabaro3009