chore: improve update

0xPolygonID · Dec 27, 2024 · c5f1592 · c5f1592
1 parent 1b83f9a
commit c5f1592
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 5 deletions.
diff --git a/internal/core/services/schema.go b/internal/core/services/schema.go
@@ -137,5 +137,10 @@ func (s *schema) Update(ctx context.Context, schema *domain.Schema) error {
 			return ErrDisplayMethodNotFound
 		}
 	}
-	return s.repo.Update(ctx, schema)
+	schemaInDatabase, err := s.repo.GetByID(ctx, schema.IssuerDID, schema.ID)
+	if err != nil {
+		return err
+	}
+	schemaInDatabase.DisplayMethodID = schema.DisplayMethodID
+	return s.repo.Save(ctx, schemaInDatabase)
 }
diff --git a/internal/repositories/schema.go b/internal/repositories/schema.go
@@ -49,7 +49,11 @@ func NewSchema(conn db.Storage) *schema {
 
 // Save stores a new entry in schemas table
 func (r *schema) Save(ctx context.Context, s *domain.Schema) error {
-	const insertSchema = `INSERT INTO schemas (id, issuer_id, url, type,  context_url, hash,  words, created_at, version, title, description, display_method_id) VALUES($1, $2, $3, $4, $5, $6, $7, $8,$9,$10,$11,$12);`
+	const insertSchema = `INSERT INTO schemas (id, issuer_id, url, type,  context_url, hash,  words, created_at, version, title, description, display_method_id) VALUES($1, $2, $3, $4, $5, $6, $7, $8, $9, $10, $11, $12)
+ 	ON CONFLICT (id) DO
+    UPDATE 
+	SET issuer_id=$2, url=$3, type=$4, context_url=$5, hash=$6,  words=$7, created_at=$8, version=$9, title=$10, description=$11, display_method_id=$12`
+
 	hash, err := s.Hash.MarshalText()
 	if err != nil {
 		return err
@@ -86,9 +90,9 @@ func (r *schema) Save(ctx context.Context, s *domain.Schema) error {
 
 func (r *schema) Update(ctx context.Context, schema *domain.Schema) error {
 	const updateSchema = `
-UPDATE schemas 
-SET issuer_id=$2, url=$3, type=$4, context_url=$5, hash=$6,  words=$7, created_at=$8, version=$9, title=$10, description=$11, display_method_id=$12
-WHERE schemas.id = $1;`
+	UPDATE schemas 
+	SET issuer_id=$2, url=$3, type=$4, context_url=$5, hash=$6,  words=$7, created_at=$8, version=$9, title=$10, description=$11, display_method_id=$12
+	WHERE schemas.id = $1;`
 	hash, err := schema.Hash.MarshalText()
 	if err != nil {
 		return err

diff --git a/internal/repositories/schema_test.go b/internal/repositories/schema_test.go
@@ -86,6 +86,7 @@ func TestCreateSchema(t *testing.T) {
 	}
 
 	require.NoError(t, store.Save(ctx, schema1))
+	schema1.ID = uuid.New()
 	assert.ErrorIs(t, ErrDuplicated, store.Save(ctx, schema1), "cannot have duplicated schemas with the same version for the same issuer and type")
 
 	schema2 := schema1