feat: PIP-42 change token to POL #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
dev1644
reviewed
May 13, 2024
There was a problem hiding this comment.
The successful conversion from MATIC to POL is assured, whereas the reverse may not be as reliable. This discrepancy warrants further discussion. Presently, there is a trend of conversions from POL to MATIC occurring in the following operational contexts:
The _transferToken function includes an option to convert POL to MATIC, through following paths -
- Drain actions performed by Governance
unstakeClaim_liquidateRewardsfunction, further segmented into:withdrawRewardsfunction_unstakeoperations, encompassing:forceUnstakeLegacyfunctionunstakeLegacyfunctiondethroneAndStakeLegacyfunction
| uint256 heimdallFee /** for new validator */ | ||
| ) external onlyWhenUnlocked { | ||
| function confirmAuctionBid(uint256 validatorId, uint256 heimdallFee) | ||
| /** |
dev1644
approved these changes
Jul 25, 2024
|
|
||
| function _delegationDeposit(uint256 amount, address delegator, bool pol) internal returns (bool) { | ||
| IERC20 token_ = _getToken(pol); | ||
| bool result = token_.transferFrom(delegator, address(this), amount); |
There was a problem hiding this comment.
Can refactor this -
_transferTokenFrom(delegator, address(this), amount, pol)
Unstake only active validators
Fix/pol upgrade review
|
simonDos
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Transition
StakeManagerto POL.See PIP-42 discussion
Solution
Use POL by default in
StakeManager.Add legacy support for MATIC <> POL conversion in
StakeManagerandValidatorShare.Todo
StakeManager.StakeManagerto POL.DefaultEmissionManagerinpol-tokenrepo to not unmigrate rewards. See pol-token/pull/60