Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: minor updates #56

Closed
wants to merge 8 commits into from
Closed

doc: minor updates #56

wants to merge 8 commits into from

Conversation

leovct
Copy link
Member

@leovct leovct commented Dec 1, 2023

A few minor updates to README.md and to script/utils/extract.js.

Before the fix.

root@workload:/app/pol-token# node script/utils/extract.js 1 '1.1.0' 'Deploy.s.sol'
/app/pol-token/script/utils/extract.js:99
          throw new Error(
                ^

Error: Implementation for PolygonMigration(0x29e7DF7b6A1B2b07b731457f499E1696c60E2C4e) did not change - 0x550B7CDaC6F5a0d9e840505c3Df74aC045530446, deployed - 0x0E695f36ADe2A12ABEa51622e80F105e125d1d6e
    at main (/app/pol-token/script/utils/extract.js:99:17)
    at Object.<anonymous> (/app/pol-token/script/utils/extract.js:501:1)
    at Module._compile (node:internal/modules/cjs/loader:1198:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1252:10)
    at Module.load (node:internal/modules/cjs/loader:1076:32)
    at Function.Module._load (node:internal/modules/cjs/loader:911:12)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:81:12)
    at node:internal/main/run_main_module:22:47
root@workload:/app/pol-token# node script/utils/extract.js 1 '1.1.0' 'Deploy.s.sol'
/app/pol-token/script/utils/extract.js:99
          throw new Error(
                ^

Error: Implementation for PolygonMigration(0x29e7DF7b6A1B2b07b731457f499E1696c60E2C4e) did not change - 0x550B7CDaC6F5a0d9e840505c3Df74aC045530446, deployed - 0x0E695f36ADe2A12ABEa51622e80F105e125d1d6e
    at main (/app/pol-token/script/utils/extract.js:99:17)
    at Object.<anonymous> (/app/pol-token/script/utils/extract.js:501:1)
    at Module._compile (node:internal/modules/cjs/loader:1198:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1252:10)
    at Module.load (node:internal/modules/cjs/loader:1076:32)
    at Function.Module._load (node:internal/modules/cjs/loader:911:12)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:81:12)
    at node:internal/main/run_main_module:22:47

After the fix.

root@workload:/app/pol-token# node script/utils/extract.js 1 '1.1.0' 'Deploy.s.sol'
Error: Implementation for PolygonMigration(0x29e7DF7b6A1B2b07b731457f499E1696c60E2C4e) did not change - 0x550B7CDaC6F5a0d9e840505c3Df74aC045530446, deployed - 0x0E695f36ADe2A12ABEa51622e80F105e125d1d6e
    at main (/app/pol-token/script/utils/extract.js:100:19)
    at Object.<anonymous> (/app/pol-token/script/utils/extract.js:506:1)
    at Module._compile (node:internal/modules/cjs/loader:1198:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1252:10)
    at Module.load (node:internal/modules/cjs/loader:1076:32)
    at Function.Module._load (node:internal/modules/cjs/loader:911:12)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:81:12)
    at node:internal/main/run_main_module:22:47

Copy link

sonarcloud bot commented Dec 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@leovct leovct changed the base branch from main to dev January 2, 2024 14:07
@leovct leovct closed this by deleting the head repository Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants