Improved test coverage #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QEDK
suggested changes
Aug 14, 2023
| @@ -20,6 +20,8 @@ contract DefaultInflationManager is Initializable, Ownable2StepUpgradeable, IMin | |||
| uint256 public treasuryMintPerSecond; | |||
| uint256 public lastMint; | |||
|
|
|||
| constructor() initializer {} | |||
There was a problem hiding this comment.
I don't think it makes sense to increase deployment costs for the purposes of coverage. Also, won't this mean that we cannot call initialize() after this?
There was a problem hiding this comment.
I added constructor here so that we don't need to send another transaction to initialize the implementation contract.
won't this mean that we cannot call initialize() after this?
Aren't we using Proxy to interact with DefualtInflationManager? In that case using constructor here is better because proxy's can be initialized when we will deploy it (Proxy).
fixed test case
dev1644
force-pushed
the
dev/improved-test-coverage
branch
from
520be8a
to
065dd3a
Compare
|
outdated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
forge fmt)