Rework third chapter #41
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexander Kuleshov <[email protected]>
Signed-off-by: Alexander Kuleshov <[email protected]>
Signed-off-by: Alexander Kuleshov <[email protected]>
Signed-off-by: Alexander Kuleshov <[email protected]>
Signed-off-by: Alexander Kuleshov <[email protected]>
Signed-off-by: Alexander Kuleshov <[email protected]>
Signed-off-by: Alexander Kuleshov <[email protected]>
Signed-off-by: Alexander Kuleshov <[email protected]>
Signed-off-by: Alexander Kuleshov <[email protected]>
klaudiagrz
reviewed
Jan 11, 2025
|
Please adjust the descriptions also in the code sample of the third post. |
klaudiagrz
reviewed
Jan 11, 2025
Signed-off-by: Alexander Kuleshov <[email protected]>
klaudiagrz
reviewed
Jan 12, 2025
klaudiagrz
reviewed
Jan 12, 2025
Signed-off-by: Alexander Kuleshov <[email protected]>
Yimura
suggested changes
Feb 6, 2025
There was a problem hiding this comment.
I came here because I was quite confused by the div instruction (where does the quotient go and what happens to the dropped number/remainder of the integer?).
Basically what I've done is fixed some of the sentence structuring and typo's related to this.
Review comments with indentation in them means that you've used mixed indentations across lines. For example the below piece of assembly:
;; This will give us the numeric value of the character.
sub bl, 48The comment is indented with spaces and the assembly is indented with a HARD tab \t.
To the compiler this makes no difference but for the reader it comes off as messy.
|
@Yimura thank you very much for your comments, I will fix in the near time. |
thanks to @Yimura Signed-off-by: Alexander Kuleshov <[email protected]>
Signed-off-by: Alexander Kuleshov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR provides rework of the third chapter.