This repository has been archived by the owner on Jul 12, 2021. It is now read-only.
MAE-2249 - Updated jquery version/page requires #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This is Logan Reynolds with Remote-Learner. We've recently received a request to review your plugin report_deviceanalytics, and although it does pass operational tests for basic install/access/uninstall on Moodle 3.0 and 3.1, I noticed that it relies on a much older version of JQuery and felt this should be updated (JQuery 1.12.1 as opposed to latest 3.0.0.) Note that in the future javascript should be written in AMD Modules per documentation at https://docs.moodle.org/dev/jQuery , however this is a gradual transition for all of us and in order to address the immediate need I've simply submitted this pull request to substitute the latest JQuery directly in the module’s ‘libs’ directory. Please let me know if you have any questions, and I will watch for any updates to the official repository on Moodle.org.
Regards,
Logan Reynolds