Add missing kaze BGM in OG mode #77
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: in the OG game, the BGM continues into the eyecatch. For this to happen, there can't be a fadeout in this script - all the BGM fadeouts happen in the next script.
|
it appears our script fades out BGM a little early compared to the OG game (see https://youtu.be/2QPHmigEfB4?t=3281) so I've made sure to only fade out BGM early in default/Mangagamer BGM mode. |
|
I'm putting this PR hold for now, it appears there are more changes than I thought required to match the original game. TODO:
|
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: in the OG game, the BGM continues into the eyecatch. For this to happen, there can't be a fadeout in this script - all the BGM fadeouts happen in the next script.