feat: query 支持 undefind、null 等参数

07akioni · Nov 1, 2023 · 77e6540 · 77e6540
1 parent 07580ed
commit 77e6540
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 5 deletions.
diff --git a/packages/core/src/core.ts b/packages/core/src/core.ts
@@ -129,9 +129,13 @@ export function createLyla<C, M extends LylaAdapterMeta>(
 
     // Resolve query string, patch it to URL
     if (_options.query) {
-      const urlSearchParams = new URLSearchParams(
-        _options.query as Record<string, string>
-      )
+      const resolvedQuery: Record<string, string> = {}
+      for (const key in _options.query) {
+        const v = _options.query[key]
+        if (v === undefined || v === null) continue
+        resolvedQuery[key] = v.toString()
+      }
+      const urlSearchParams = new URLSearchParams(resolvedQuery)
       const queryString = urlSearchParams.toString()
       if (_options.url.includes('?')) {
         throw defineLylaError<M, C, LylaBadRequestError<C, M>>(

diff --git a/packages/core/src/types.ts b/packages/core/src/types.ts
@@ -1,4 +1,8 @@
-import type { LylaDataConversionError, LylaError, LylaResponseError } from './error'
+import type {
+  LylaDataConversionError,
+  LylaError,
+  LylaResponseError
+} from './error'
 
 export type LylaMethod =
   | 'get'
@@ -49,7 +53,7 @@ export type LylaRequestOptions<
    * `body`.
    */
   json?: any
-  query?: Record<string, string | number>
+  query?: Record<string, string | number | boolean | undefined | null>
   baseUrl?: string
   /**
    * Abort signal of the request.