Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CON-1810-MARKDOWN-drawing-raid-for-Java-piscine #2099

Merged
merged 8 commits into from
Aug 5, 2023
Merged

CON-1810-MARKDOWN-drawing-raid-for-Java-piscine #2099

merged 8 commits into from
Aug 5, 2023

Conversation

Hamzaelkhatri
Copy link
Member

docs(Jart):add the audit of jart raid

Before starting, please choose the relevant pull request Labels, Reviewers, and Assignees

Why?

Clearly state the reason for this change. What problem is it solving or feature is it adding?

Solution Overview

Provide an overview of the solution implemented in this pull request. This should be a high level overview without getting into technical details. If applicable, include screenshots of UI or use GitHub compliant mermaid graphs to visually represent the solution.

Implementation Details

Explain the details of the implementation and the reasoning behind it. What alternative approaches were considered and why was this approach chosen?

@Hamzaelkhatri
docs(Jart):add the subject jart
828f125 
docs(Jart):add the audit of jart raid
zanninso
zanninso requested changes Jul 27, 2023
View reviewed changes
Copy link
Contributor

@zanninso zanninso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please resolve the added conversations

zanninso
zanninso approved these changes Aug 5, 2023
View reviewed changes
Copy link
Contributor

@zanninso zanninso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zanninso zanninso merged commit 4343e5d into master Aug 5, 2023
2 checks passed
@zanninso zanninso deleted the CON-1810-MARKDOWN-drawing-raid-for-Java-piscine branch August 5, 2023 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zanninso zanninso zanninso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Hamzaelkhatri @zanninso