-
-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make bytes dependency optional #52
Conversation
@jklmnn Builds are failing, here is the error. please check? |
The problem seems to be that There are 2 instances I have identified so far. The first one is the one in your screenshot. Here I'm not sure what the intention is. Line 118 in 0f1ce9d
bytes in decoder_test . Since the test input is the same for the version with and without bytes my guess is that it is intended. I made this test dependent on std which seems to fix it.
The other problems are the examples. E.g. Line 70 in 0f1ce9d
bytes here seems to be the test data (and the example on how to use bytes with the API) I think we could remove them. But I don't have a really strong opinion on that.
I haven't looked into how |
You can disable doctests for specific cfg like this: https://users.rust-lang.org/t/how-to-disable-documentation-testing-for-specific-platforms/5059 |
@mchodzikiewicz I have disabled the doc tests in the workflow itself by running them with @00imvj00 the tests should work now. I have also added a check running |
ref #51