Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong function codes in modbus.rs #15

Open
Ibens3C opened this issue Jan 18, 2022 · 0 comments
Open

Wrong function codes in modbus.rs #15

Ibens3C opened this issue Jan 18, 2022 · 0 comments

Comments

@Ibens3C
Copy link

Ibens3C commented Jan 18, 2022

Hi,
in the modbus.rs file is pub enum FunctionCode, where the default Modbus function codes are defined.
I've noticed, that the codes were taken over from decimal format and are defined as hex. This seems to be wrong.
For example:

/// 0x15 Write Multiple Coils
WriteMultipleCoils = 0x15,

should be

/// 15 Write Multiple Coils
WriteMultipleCoils = 0x0F,
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant