Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ionic 4 version doesn't work well on device: cannot change active tab #374

Closed
agrinko opened this issue Apr 26, 2019 · 5 comments
Closed

Comments

@agrinko
Copy link

agrinko commented Apr 26, 2019

I cloned the latest version of https://github.com/zyra/ionic-super-tabs-example and installed all dependencies. It works fine in the browser. I also updated my own application to the latest version of Ionic Super tabs (v6.0.0-beta.8), and it's also working fine in browser.

Both applications are installed correctly on device, I can see the interface outside of super-tabs, and I can see super tabs toolbar. But changing tabs doesn't work. Tab buttons are clickable, indicator moves left and right, but content is not changed and also I cannot swipe.

This happens on both Android and iOS emulators.

I know Super Tabs for Ionic 4 is still in beta, just wanted to ensure you don't miss this issue. I'd be really thankful for any updates on this. It prevents me from upgrading my app to Ionic 4.

P.S: created a duplicate issue there as well, wasn't sure what's the right place for it
zyra/ionic-super-tabs-example#31

@agrinko agrinko changed the title Latest version doesn't work well on device Latest version doesn't work well on device: cannot change active tab Apr 26, 2019
@agrinko agrinko changed the title Latest version doesn't work well on device: cannot change active tab Ionic 4 version doesn't work well on device: tab content is Apr 26, 2019
@agrinko agrinko changed the title Ionic 4 version doesn't work well on device: tab content is Ionic 4 version doesn't work well on device: cannot change active tab Apr 26, 2019
@st3h3n
Copy link

st3h3n commented Apr 26, 2019

@agrinko this is the right place as it is clearly an issue with ST not the example implementation.

I can confirm this issue on an actual device (iPhone 6s, Safari, iOS 12.2). Unfortunately this issue doesn't throw an error on the iPhone, so I tried it in an older Android browser and could reproduce the same issue. In the old Android browser it throws this error:

TypeError: r.scrollTo is not a function
    at scroll (chunk-39d8d03b.js:1)
    at Array.<anonymous> (chunk-39d8d03b.js:1)
    at p (supertabs.core.js:5)
    at d (supertabs.core.js:5)
    at ZoneDelegate.push../node_modules/zone.js/dist/zone.js.ZoneDelegate.invokeTask (zone.js:423)
    at Object.onInvokeTask (core.js:17289)
    at ZoneDelegate.push../node_modules/zone.js/dist/zone.js.ZoneDelegate.invokeTask (zone.js:422)
    at Zone.push../node_modules/zone.js/dist/zone.js.Zone.runTask (zone.js:195)
    at push../node_modules/zone.js/dist/zone.js.ZoneTask.invokeTask (zone.js:498)
    at ZoneTask.invoke (zone.js:487)

Hope it helps.

@st3h3n
Copy link

st3h3n commented May 10, 2019

#379 fixed this

@agrinko
Copy link
Author

agrinko commented May 12, 2019

@st3h3n , that's great, thank you!
Don't you know when it is going to be released (i.e. tagged beta.9)?

@st3h3n
Copy link

st3h3n commented May 17, 2019

no, but you can fix it yourself in the meantime:

super-tabs-container {
  height: 100%!important;
}

@agrinko
Copy link
Author

agrinko commented May 17, 2019

Good idea, thank you!

@agrinko agrinko closed this as completed May 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants