Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch_FloatMenuMakerMap_ChoicesAtFor prevents prioritizing repairs on a storage unit #606

Open
Sn1p3rr3c0n opened this issue Jul 23, 2022 · 2 comments · May be fixed by #618
Open

Patch_FloatMenuMakerMap_ChoicesAtFor prevents prioritizing repairs on a storage unit #606

Sn1p3rr3c0n opened this issue Jul 23, 2022 · 2 comments · May be fixed by #618
Labels
bug Something isn't working C#

Comments

@Sn1p3rr3c0n
Copy link
Collaborator

Patch_FloatMenuMakerMap_ChoicesAtFor Is used to hide the potentially huge right click menu when clicking on an storage create.

As a side effect it also hides the option to prioritise a repair of the storage building.
@Sn1p3rr3c0n Sn1p3rr3c0n added bug Something isn't working C# labels Jul 23, 2022
@Sn1p3rr3c0n Sn1p3rr3c0n mentioned this issue Aug 19, 2022
Closed
Sn1p3rr3c0n added a commit that referenced this issue Sep 18, 2022
@Sn1p3rr3c0n
#606 added drafted repair option
38c09ee
@Sn1p3rr3c0n
Copy link
Collaborator Author

38c09ee Adds the Vanilla Drafted implementation for adding the repair Float Menu.
This means there is no check if the pawn is assigned to repair.
While it would be possible to add that check if that work is allowed I suspect it might cause issues with Personal Work Categories

As a alternative i might make sense to check if we can make the patch more targeted to hide the options for items specifically

@Sn1p3rr3c0n Sn1p3rr3c0n linked a pull request Sep 18, 2022 that will close this issue
Draft
1 task
@Sn1p3rr3c0n
Copy link
Collaborator Author

Sn1p3rr3c0n commented Feb 4, 2023 •
edited
Loading

If we Patch FloatMenuMakerMap.AddHumanlikeOrders instead we retain the repair option.

  • Some of the Merge Options
    image
    Picture is with ~280 Stacks

Removing those would require a Transpiler in imWorld.FloatMenuMakerMap.AddJobGiverWorkOrders

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working C#
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#606 added drafted repair option zymex22/Project-RimFactory-Revived
1 participant
@Sn1p3rr3c0n