Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Items Itab add a Toggle button fuzzy search #300

Closed
zymex22 opened this issue Dec 14, 2020 · 7 comments
Closed

Items Itab add a Toggle button fuzzy search #300

zymex22 opened this issue Dec 14, 2020 · 7 comments
Labels
C# enhancement New feature or request minor

Comments

@zymex22
Copy link
Owner

zymex22 commented Dec 14, 2020

when i click use on a pawn and pawn will come and pickup pants.... it will throw this:
image

image

image

Exception filling tab ProjectRimFactory.Storage.UI.ITab_Items: System.NullReferenceException: Object reference not set to an instance of an object
  at ProjectRimFactory.Storage.UI.ITab_Items.DrawThingRow (System.Single& y, System.Single width, Verse.Thing thing) [0x00109] in <1e70a838b9e54f7ca442a6e30dafcfe1>:0 
  at ProjectRimFactory.Storage.UI.ITab_Items.FillTab () [0x00256] in <1e70a838b9e54f7ca442a6e30dafcfe1>:0 
  at Verse.InspectTabBase+<>c__DisplayClass14_0.<DoTabGUI>b__0 () [0x00039] in <d72310b4d8f64d25aee502792b58549f>:0 
Verse.Log:Error(String, Boolean)
Verse.Log:ErrorOnce(String, Int32, Boolean)
Verse.<>c__DisplayClass14_0:<DoTabGUI>b__0()
Verse.ImmediateWindow:DoWindowContents(Rect)
Verse.Window:InnerWindowOnGUI(Int32)
UnityEngine.GUI:CallWindowDelegate(WindowFunction, Int32, Int32, GUISkin, Int32, Single, Single, GUIStyle)

because it clicked force equip on a pawn and WHEN pawn come and pick it up it ofc throw that error because its not on list anymore
if i use drop/output button it isnt a problem though

@lilwhitemouse
Copy link
Collaborator

Suggested first attempt to solve this:

First line of DrawThingRow should probably be if (thing==null) return;

@zymex22
Copy link
Owner Author

zymex22 commented Dec 14, 2020

Should add a toggle button for on/off fuzzy search @Riderfighter said was missing and todo for later

This update may be made with #178

@zymex22 zymex22 added bug Something isn't working C# labels Dec 14, 2020
@lilwhitemouse
Copy link
Collaborator

2nd line should probably be
if (!thing.Spawned) return;

@techno156
Copy link

techno156 commented Jan 6, 2021

Related:
DSU item list has poor performance if there is a large number of items in the DSU (> 100 stacks). Tested in both vanilla and modded games. This performance impact seems to only affect the DSU, as other storage mods are not affected, and was not observed to occur in older version of RimFactory, that had the old DSU item list behaviour.

Performance decreases as the number of items in the DSU increases, to the point where a vanilla game can experience noticeable lag at high item stack counts (> 500 stacks) if the DSU item list is open.

@zymex22 zymex22 changed the title DSU new system test/bugs (Bug report) Items Itab add a Toggle button fuzzy search Jan 23, 2021
@zymex22 zymex22 added enhancement New feature or request minor and removed bug Something isn't working labels Jan 23, 2021
@Sn1p3rr3c0n
Copy link
Collaborator

@Sn1p3rr3c0n
Copy link
Collaborator

Toggle has been added with #760
Still need to do that check

@Sn1p3rr3c0n
Copy link
Collaborator

Can't cause any spammy errors.
Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C# enhancement New feature or request minor
Projects
None yet
Development

No branches or pull requests

4 participants