Merge pull request #530 from sc-atompower/feature/noposter

allows the poster attribute of the html video tag to be bindable.
zxing-js · Jul 21, 2023 · 190742b · 190742b
2 parents 3daa74e + 180964d
commit 190742b
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/projects/zxing-scanner/src/lib/zxing-scanner.component.html b/projects/zxing-scanner/src/lib/zxing-scanner.component.html
@@ -1,4 +1,4 @@
-<video #preview [style.object-fit]="previewFitMode" poster="noposter">
+<video #preview [style.object-fit]="previewFitMode" [poster]="poster">
   <p>
     Your browser does not support this feature, please try to upgrade it.
   </p>

diff --git a/projects/zxing-scanner/src/lib/zxing-scanner.component.ts b/projects/zxing-scanner/src/lib/zxing-scanner.component.ts
@@ -122,6 +122,12 @@ export class ZXingScannerComponent implements OnInit, OnDestroy {
   @Input()
   previewFitMode: 'fill' | 'contain' | 'cover' | 'scale-down' | 'none' = 'cover';
 
+  /**
+   * Url of the HTML video poster
+   */
+  @Input()
+  poster: string = '';
+
   /**
    * Emits events when the torch compatibility is changed.
    */
@@ -757,7 +763,7 @@ export class ZXingScannerComponent implements OnInit, OnDestroy {
     if (!this._codeReader) {
       const options = {
         delayBetweenScanAttempts: this.timeBetweenScans,
-        delayBetweenScanSuccess: this.delayBetweenScanSuccess,
+        delayBetweenScanSuccess: this.delayBetweenScanSuccess
       };
       this._codeReader = new BrowserMultiFormatContinuousReader(this.hints, options);
     }
@@ -784,7 +790,8 @@ export class ZXingScannerComponent implements OnInit, OnDestroy {
 
     const next = (x: ResultAndError) => this._onDecodeResult(x.result, x.error);
     const error = (err: any) => this._onDecodeError(err);
-    const complete = () => { };
+    const complete = () => {
+    };
 
     this._scanSubscription = scanStream.subscribe(next, error, complete);