Skip to content

Commit a4d86b5

Browse files
committed
deps: Run yarn upgrade
This is step one toward #5847. We hold back react-native-screens at 3.29.0. That's because 3.30 breaks compatibility with RN v0.68 in a certain way, and although the 3.31 release candidate addresses one source of that incompatibility -- software-mansion/react-native-screens#2088 -- there seems to be another. In particular, after the app starts up on Android, I get errors: Error: Requiring module "node_modules/react-native-screens/src/index.tsx", which threw an exception: Error: Exception in HostObject::get(propName:RNSModule): java.lang.UnsatisfiedLinkError: dalvik.system.PathClassLoader[DexPathList[[zip file "/data/app/com.zulipmobile.debug-cCKhUjMGcecB6tGNtf5jiQ==/base.apk"],nativeLibraryDirectories=[/data/app/com.zulipmobile.debug-cCKhUjMGcecB6tGNtf5jiQ==/lib/arm64, /data/app/com.zulipmobile.debug-cCKhUjMGcecB6tGNtf5jiQ==/base.apk!/lib/arm64-v8a, /system/lib64]]] couldn't find "librnscreens.so" […] and TypeError: undefined is not an object (evaluating '_$$_REQUIRE(_dependencyMap[16], "react-native-screens").screensEnabled') This error is located at: in CardStack (at StackView.tsx:462) in KeyboardManager (at StackView.tsx:458) in SafeAreaProviderCompat (at StackView.tsx:455) in RNGestureHandlerRootView (at GestureHandlerRootView.android.tsx:22) in GestureHandlerRootView (at StackView.tsx:454) in StackView (at createStackNavigator.tsx:87) in StackNavigator (at AppNavigator.js:140) in AppNavigator (at ZulipNavigationContainer.js:65) in EnsureSingleNavigator (at BaseNavigationContainer.tsx:411) in BaseNavigationContainer (at NavigationContainer.tsx:91) in ThemeProvider (at NavigationContainer.tsx:90) in NavigationContainer (at ZulipNavigationContainer.js:58) in ZulipAppContainer (at ZulipMobile.js:83) […] which I don't really understand but I suspect might require us to adopt React Native's "Fabric" system which we don't want to bother with for this legacy app.
1 parent cb4a07e commit a4d86b5

File tree

4 files changed

+1051
-981
lines changed

4 files changed

+1051
-981
lines changed

ios/Podfile.lock

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -338,7 +338,7 @@ PODS:
338338
- React
339339
- RNCPushNotificationIOS (1.11.0):
340340
- React-Core
341-
- RNGestureHandler (2.15.0):
341+
- RNGestureHandler (2.16.0):
342342
- React-Core
343343
- RNReanimated (2.2.4):
344344
- DoubleConversion
@@ -372,14 +372,14 @@ PODS:
372372
- RNScreens (3.29.0):
373373
- React-Core
374374
- React-RCTImage
375-
- RNSentry (5.19.0):
375+
- RNSentry (5.20.0):
376376
- React-Core
377-
- Sentry/HybridSDK (= 8.17.1)
377+
- Sentry/HybridSDK (= 8.21.0)
378378
- RNVectorIcons (9.2.0):
379379
- React-Core
380-
- Sentry/HybridSDK (8.17.1):
381-
- SentryPrivate (= 8.17.1)
382-
- SentryPrivate (8.17.1)
380+
- Sentry/HybridSDK (8.21.0):
381+
- SentryPrivate (= 8.21.0)
382+
- SentryPrivate (8.21.0)
383383
- Toast (4.0.0)
384384
- Yoga (1.14.0)
385385

@@ -640,13 +640,13 @@ SPEC CHECKSUMS:
640640
RNCClipboard: 60fed4b71560d7bfe40e9d35dea9762b024da86d
641641
RNCMaskedView: 0e1bc4bfa8365eba5fbbb71e07fbdc0555249489
642642
RNCPushNotificationIOS: 64218f3c776c03d7408284a819b2abfda1834bc8
643-
RNGestureHandler: 0cba6c7c51a90cd793cf2475cf7fdca613ede300
643+
RNGestureHandler: 998887f1b2c6098ffa2506402087c0e8ef5d69a1
644644
RNReanimated: e7d8afaf8fed4b3bf1a46e06adb2e04a2b248f1c
645645
RNScreens: fa9b582d85ae5d62c91c66003b5278458fed7aaa
646-
RNSentry: 31f4e38ea1d87d3693f634cbe377640bde583588
646+
RNSentry: f30463ce11af9cfec0dde79265d29e10c3b902d7
647647
RNVectorIcons: fcc2f6cb32f5735b586e66d14103a74ce6ad61f8
648-
Sentry: d9f99f9cc13777c5d938650c1e1c85047bb4f0d1
649-
SentryPrivate: 839b1e58addf58624087a80b2628e543193fa8ef
648+
Sentry: ebc12276bd17613a114ab359074096b6b3725203
649+
SentryPrivate: d651efb234cf385ec9a1cdd3eff94b5e78a0e0fe
650650
Toast: 91b396c56ee72a5790816f40d3a94dd357abc196
651651
Yoga: 0bc4b37c3b8a345336ff601e2cf7d9704bab7e93
652652

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@
6565
"react-native-photo-view": "alwx/react-native-photo-view#91b873c85",
6666
"react-native-reanimated": "^2.2.0 <2.3.0",
6767
"react-native-safe-area-context": "^4.3.1",
68-
"react-native-screens": "^3.13.1",
68+
"react-native-screens": "^3.13.1 <3.30.0",
6969
"react-native-simple-toast": "^1.1.4",
7070
"react-native-tab-view": "^2.15.2",
7171
"react-native-url-polyfill": "^1.3.0",

src/webview/js/generatedEs3.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ var compiledWebviewJs = (function (exports) {
4848
}
4949
function _toPropertyKey(t) {
5050
var i = _toPrimitive(t, "string");
51-
return "symbol" == typeof i ? i : String(i);
51+
return "symbol" == typeof i ? i : i + "";
5252
}
5353
function _defineProperty(obj, key, value) {
5454
key = _toPropertyKey(key);

0 commit comments

Comments
 (0)