Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle legacy message_inline_ref Dropbox previews #962

Open
gnprice opened this issue Sep 25, 2024 · 0 comments
Open

Handle legacy message_inline_ref Dropbox previews #962

gnprice opened this issue Sep 25, 2024 · 0 comments
Labels
a-content Parsing and rendering Zulip HTML content, notably message contents
Milestone

Comments

@gnprice
Copy link
Member

gnprice commented Sep 25, 2024

Some messages' content can have an HTML element like <div class="message_inline_ref">.

This is a legacy Zulip feature; it's still live in current servers, but looks broken in current web clients. I think we hadn't thought about it in a number of years, until it was discovered in the #917 / #190 survey of content features not yet implemented in this new mobile app. The next time we spend effort on it on the server or web side, it'll probably involve eliminating this feature from the HTML.

Given that context, supporting these is a low priority. Filing this issue so we can track it, though.

Chat thread: https://chat.zulip.org/#narrow/stream/9-issues/topic/message_inline_ref.20dropbox.20links/near/1934079

Original notes (with a link fixed) by @PIG208 in #921:

Added here. This pretty much a dropbox-specific link preview (this line of code is 10 years old) for non-images. This still can be generated by the server. (example)

@gnprice gnprice added the a-content Parsing and rendering Zulip HTML content, notably message contents label Sep 25, 2024
@gnprice gnprice added this to the Post-launch milestone Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-content Parsing and rendering Zulip HTML content, notably message contents
Projects
Status: No status
Development

No branches or pull requests

1 participant