Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle "timestamp-error" <span> elements #922

Open
PIG208 opened this issue Aug 30, 2024 · 1 comment
Open

Handle "timestamp-error" <span> elements #922

PIG208 opened this issue Aug 30, 2024 · 1 comment
Labels
a-content Parsing and rendering Zulip HTML content, notably message contents
Milestone

Comments

@PIG208
Copy link
Member

PIG208 commented Aug 30, 2024

When a timestamp is created in a broken format (such as <time:asdasd>), the server generates a span element with the timestamp-error class.

We should handle that and display something like "Invalid time format: asdasd" like the server does.

Example

@PIG208 PIG208 changed the title <span class="timestamp-error">: (example) Handle "timestamp-error" inline elements Aug 30, 2024
@PIG208 PIG208 changed the title Handle "timestamp-error" inline elements Handle "timestamp-error" <span> elements Aug 30, 2024
@PIG208 PIG208 added the a-content Parsing and rendering Zulip HTML content, notably message contents label Aug 30, 2024
@PIG208 PIG208 added this to the Launch milestone Aug 30, 2024
@gnprice
Copy link
Member

gnprice commented Sep 25, 2024

Pushing to post-launch as this is difficult to trigger accidentally, and empirically rare: 10 examples in your survey results in #921, the latest of them in 2021. (And the consequences are limited when it does happen: the one affected message shows one form of error instead of a different form of error.)

@gnprice gnprice modified the milestones: Launch, Post-launch Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-content Parsing and rendering Zulip HTML content, notably message contents
Projects
Status: No status
Development

No branches or pull requests

2 participants