Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide compose box based on stream posting policy #674

Open
gnprice opened this issue May 14, 2024 · 0 comments · May be fixed by #886
Open

Hide compose box based on stream posting policy #674

gnprice opened this issue May 14, 2024 · 0 comments · May be fixed by #886
Assignees
Labels
a-compose Compose box, autocomplete, attaching files/images

Comments

@gnprice
Copy link
Member

gnprice commented May 14, 2024

When this Zulip feature is in effect:
https://zulip.com/help/stream-sending-policy
it may mean that the self-user wouldn't be able to send to a given stream. When that's the case, we should replace the compose box with a banner explaining this is the case.

In the API, this is ZulipStream.streamPostPolicy.

In zulip-mobile we have a version of this, but it only detects "announcement-only" streams, i.e. where the policy is StreamPostPolicy.administrators. (Because long ago that was the only version that existed.) Just recently I happened to see a user get affected by this on a stream where the policy was StreamPostPolicy.moderators and they weren't a moderator — the symptom (on zulip-mobile) was that the app tries to send and then the message just sits there with an outbox spinner forever. So that underlines that this feature is a meaningful one which we should be sure to implement (and do so completely).

@gnprice gnprice added the a-compose Compose box, autocomplete, attaching files/images label May 14, 2024
@gnprice gnprice added this to the Beta 3: Summer 2024 milestone May 14, 2024
@sm-sayedi sm-sayedi self-assigned this Aug 8, 2024
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Aug 12, 2024
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Aug 12, 2024
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Aug 13, 2024
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Aug 13, 2024
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Aug 14, 2024
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Aug 15, 2024
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Aug 16, 2024
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Aug 19, 2024
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Aug 20, 2024
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Aug 22, 2024
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-compose Compose box, autocomplete, attaching files/images
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

2 participants