Skip to content

Fix "private"/"PM" stragglers on the internal side of our API bindings #785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gnprice opened this issue Jul 2, 2024 · 0 comments
Open
Labels
a-api Implementing specific parts of the Zulip server API

Comments

@gnprice
Copy link
Member

gnprice commented Jul 2, 2024

This is a partial revival of:

@PIG208 noticed at #145 (comment) that we have MessageType.private, which uses the old nomenclature. It should be MessageType.direct.

Similarly we have InitialSnapshot.recentPrivateConversations; it should be InitialSnapshot.recentDmConversations.

Both of those names reflect what's in the server API. We should use JsonKey and friends so that we continue to interact with the API in the same way, and just have the modernized names within our code.

After doing those two renames, rerun this search command to look for any remaining stragglers:

$ git grep -P 'pm|Pm|PM|(?i:private)' -- lib test
@gnprice gnprice added the a-api Implementing specific parts of the Zulip server API label Jul 2, 2024
@gnprice gnprice added this to the Beta 3: Summer 2024 milestone Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-api Implementing specific parts of the Zulip server API
Projects
Status: No status
Development

No branches or pull requests

1 participant