You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@PIG208 noticed at #145 (comment) that we have MessageType.private, which uses the old nomenclature. It should be MessageType.direct.
Similarly we have InitialSnapshot.recentPrivateConversations; it should be InitialSnapshot.recentDmConversations.
Both of those names reflect what's in the server API. We should use JsonKey and friends so that we continue to interact with the API in the same way, and just have the modernized names within our code.
After doing those two renames, rerun this search command to look for any remaining stragglers:
$ git grep -P 'pm|Pm|PM|(?i:private)' -- lib test
The text was updated successfully, but these errors were encountered:
This is a partial revival of:
@PIG208 noticed at #145 (comment) that we have
MessageType.private
, which uses the old nomenclature. It should beMessageType.direct
.Similarly we have
InitialSnapshot.recentPrivateConversations
; it should beInitialSnapshot.recentDmConversations
.Both of those names reflect what's in the server API. We should use
JsonKey
and friends so that we continue to interact with the API in the same way, and just have the modernized names within our code.After doing those two renames, rerun this search command to look for any remaining stragglers:
The text was updated successfully, but these errors were encountered: