Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

msglist: There should be 36px of scrollable whitespace at bottom (emphasizing that end-of-feed is reached) #400

Closed
chrisbobbe opened this issue Nov 20, 2023 · 1 comment · Fixed by #402
Closed

msglist: There should be 36px of scrollable whitespace at bottom (emphasizing that end-of-feed is reached) #400

chrisbobbe opened this issue Nov 20, 2023 · 1 comment · Fixed by #402
Assignees
@chrisbobbe
Labels
a-design Visual and UX design a-msglist The message-list screen, except what's label:a-content

Comments

@chrisbobbe
Copy link
Collaborator

As suggested by Vlad; see discussion: https://chat.zulip.org/#narrow/stream/243-mobile-team/topic/flutter.3A.20Mark-as-read/near/1680603
@chrisbobbe chrisbobbe added the a-design Visual and UX design label Nov 20, 2023
@chrisbobbe chrisbobbe self-assigned this Nov 20, 2023
chrisbobbe added a commit to chrisbobbe/zulip-flutter that referenced this issue Nov 20, 2023
@chrisbobbe
msglist: Add 36px space at bottom, to reinforce that end-of-feed is r…
c1b1cbd 
…eached

As requested by Vlad (same link as in a code comment):
  https://chat.zulip.org/#narrow/stream/243-mobile-team/topic/flutter.3A.20Mark-as-read/near/1680603

Fixes: zulip#400
@chrisbobbe
Copy link
Collaborator Author

Fixing this should mitigate an issue where tapping the mark-as-read button can surprisingly take you to a different message list, instead of marking messages as read: #327 (comment)

We should still fix the root cause of that (see link), but this should help make it happen less frequently, by getting the button out of the area with the buggy tap response when the message list is fully scrolled to the bottom.

@chrisbobbe chrisbobbe mentioned this issue Nov 20, 2023
Merged
@gnprice gnprice added the a-msglist The message-list screen, except what's label:a-content label Nov 20, 2023
@gnprice gnprice mentioned this issue Mar 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chrisbobbe chrisbobbe

Labels
a-design Visual and UX design a-msglist The message-list screen, except what's label:a-content
Projects
Flutter app
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

msglist: Add end-of-feed whitespace; use background color from Figma chrisbobbe/zulip-flutter
2 participants
@gnprice @chrisbobbe