-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add video zoom functionality in lightbox #1302
base: main
Are you sure you want to change the base?
Conversation
Implements pinch-to-zoom and pan gestures for videos in the lightbox view. This allows users to zoom in/out (up to 5x) and pan around while maintaining proper aspect ratio. Fixes zulip#1287
Thanks. Before we can review this in detail, it will need tests. See our README, which says that and has links to more resources. This also makes several changes that seem unrelated to the issue this is meant to solve — for example removing the loading indicator. If those are unintended, you'll need to remove them. If intended, please make clear in the commit messages why those changes are desirable. See the links in our README for Zulip's Git style guide. |
I apologize for submitting the PR without proper tests and for including unintended changes
|
No need to close a PR and open a separate one — it's better to update the same PR. That keeps the discussion thread together. (You can still reopen this one.) |
Also, it looks like CI is failing; that will also need to be fixed. 🙂 |
Give me some time, I'll fixing the issue within the guidelines 😄 |
I keep getting NDK version error and trying fixing it using the upgrade script but it requires linux environment to run, can anyone guide me a little ? |
See the section in the README about asking for help — you'll get answers more effectively in Zulip following those guidelines than by trying to have the conversation in this GitHub thread. |
Implements video zooming functionality in the lightbox view as requested in #1287.
Changes made:
This enhancement allows users to:
The video controls remain accessible at the bottom of the screen while zooming.
Fixes #1287