Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the org tab list draggable in left sidebar #548

Open
akashnimare opened this issue Aug 28, 2018 · 20 comments · May be fixed by #1359
Open

Make the org tab list draggable in left sidebar #548

akashnimare opened this issue Aug 28, 2018 · 20 comments · May be fixed by #1359

Comments

@akashnimare
Copy link
Member

akashnimare commented Aug 28, 2018

We should make the organization list in the left sidebar draggable so that users can reorder the added organizations.

image

Something like this -

On a technical level we need to make following changes when the user drags the org tabs -

  • Update the index of org in the menu item

image

  • Update the index of org in the left sidebar

  • Update the tooltip

@timabbott
Copy link
Member

sortable.js is usually the way to do this sort of reordering.

@kanishk98
Copy link
Collaborator

@zulipbot claim

@kanishk98
Copy link
Collaborator

@timabbott I'm sorry, I don't understand. What do you mean when you say sortable.js? I can't find any file by that name in the repo.

@abhigyank
Copy link
Collaborator

sortable.js is a JavaScript library for reorderable drag-and-drop ( they have a repo on GitHub) . Akash has already done a lot of work on this, you can check out the org-tab-drop branch in this repo and then continue from there.

@akashnimare
Copy link
Member Author

@kanishk98 yeah the dragging part is done in the org-tab-drag. The remaining part is -

  • Update the tooltips
  • Update the index of the orgs

@kanishk98
Copy link
Collaborator

kanishk98 commented Dec 16, 2018

I've been trying to solve the tooltips problem, and I'd like some clarity here:
the initTabs() method in app/renderer/js/main.js calls initServer() using the following code:

const servers = DomainUtil.getDomains();
if (servers.length > 0) {
	for (let i = 0; i < servers.length; i++) {
		this.initServer(servers[i], i);
		DomainUtil.updateSavedServer(servers[i].url, i);
		this.activateTab(i);
	}

If we're looking to update the server icons, should we also be changing the json file containing domain information?
(Since DomainUtil.getDomains() uses that file to pass domains to servers)

@akashnimare
Copy link
Member Author

I think in order to get everything right, we gotta save the index of the domain otherwise it would be difficult to keep track of all the indexes after dragging/reloading etc.

@zulipbot
Copy link
Member

zulipbot commented Dec 26, 2018

Hello @kanishk98, you have been unassigned from this issue because you have not updated this issue or any referenced pull requests for over 14 days.

You can reclaim this issue or claim any other issue by commenting @zulipbot claim on that issue.

Thanks for your contributions, and hope to see you again soon!

@kanishk98
Copy link
Collaborator

I'm still on the issue, just been unwell these past few days. The cold's got to me, sorry. I'll get back to work on this tomorrow.

@manavmehta
Copy link
Collaborator

@zulipbot claim

@zulipbot
Copy link
Member

zulipbot commented Mar 3, 2020

Hello @manavmehta, it looks like you've currently claimed 1 issue in this repository. We encourage new contributors to focus their efforts on at most 1 issue at a time, so please complete your work on your other claimed issues before trying to claim this issue again.

We look forward to your valuable contributions!

@manavmehta
Copy link
Collaborator

@zulipbot I have already made two PRs that are pending for review. Also I am working on both of the issues.
Please allow me to take this one up too.

@abhigyank
Copy link
Collaborator

@manavmehta sure go ahead. I would suggest to build up on PR #617.

@etanter
Copy link

etanter commented Sep 16, 2021

Hi, is that feature available already? The discussion here is rather old, and I can't find a way to do that (or even in the settings). I'm on the macOS app.
Thanks!

@timabbott
Copy link
Member

It is not; the latest work is this stale PR: #1059

Contributions are welcome!

@cossio
Copy link

cossio commented Aug 31, 2022

I would really like to have this feature as well. Unfortunately it seems that the mentioned PR #1059 is stale. Are there updates happening somewhere else?

@Aitchessbee
Copy link
Collaborator

@zulipbot claim

@zulipbot
Copy link
Member

zulipbot commented Mar 1, 2024

Welcome to Zulip, @Aitchessbee! We just sent you an invite to collaborate on this repository at https://github.com/zulip/zulip-desktop/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip!

Here's some tips to get you off to a good start:

As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site.

See you on the other side (that is, the pull request side)!

@zulipbot
Copy link
Member

zulipbot commented Mar 11, 2024

@Aitchessbee You have been unassigned from this issue because you have not made any updates for over 14 days. Please feel free to reclaim the issue if you decide to pick up again. Thanks!

@Aitchessbee
Copy link
Collaborator

Still working on it!

@Aitchessbee Aitchessbee linked a pull request Mar 13, 2024 that will close this issue
3 tasks
Aitchessbee added a commit to Aitchessbee/zulip-desktop that referenced this issue Mar 13, 2024
Aitchessbee added a commit to Aitchessbee/zulip-desktop that referenced this issue Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants