Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slack Bridge: Discontinuation of classic Slack App #825

Open
PieterCK opened this issue May 13, 2024 · 2 comments · May be fixed by #826
Open

Slack Bridge: Discontinuation of classic Slack App #825

PieterCK opened this issue May 13, 2024 · 2 comments · May be fixed by #826
Assignees
@PieterCK
Labels
help wanted in progress

Comments

@PieterCK
Copy link
Collaborator

PieterCK commented May 13, 2024 •
edited
Loading

📄 Overview

Slack is discontinuing its classic Slack app. On June 4 2024, user won't be able to create the classic Slack app anymore.

This issue will highlight how this change will impact our "real-time slack mirror" feature, specifically bridge_with_slack.py and any relevant files.

Relevant links:
Discontinuing new creation of Classic Slack apps and legacy custom integration bot users

Slack Migration Guide

CZO discussion: here.

⚠️ Impacted Area

In summary, any ongoing mirrors using bridge_with_slack on a classic Slack app should continue to work. However, users won't be able to create new mirrors once the class Slack app has been discontinued because it uses RTM API. It is highly recommended by Slack to migrate to Socket Mode API.

see list of available API: slack_sdk

bridge_with_slack.py

If you're still using the RTM API, it means you haven't migrated to modern Slack apps yet, which don't support the RTM API.
https://api.slack.com/changelog/2021-10-rtm-start-to-stop#events-sockets

image

image
One recommended fix that seems to be the easiest is to just migrate to rtm.connect. However, RTM API itself must be configured using a classic Slack app. This means after June 4 2024, new Slack users won't be able to use our bridge_with_slack even when we've migrated to rtm.connect from rtm.start.

image

On the other hand, migrating to the recommended Socket Mode would likely require overhauling most of bridge_with_slack.py. However, this approach is more future-proof and allows the possibility to expand bridge_with_slack with more features provided by the Socket Mode API and other features down the line.

Documentation

 Right now it's still pointing the user to create the classic Slack app.

image
@PieterCK PieterCK changed the title Slack Bridge: Changes from modern Slack App Slack Bridge: Discontinuation of classic Slack App May 13, 2024
@zulipbot
Copy link
Member

zulipbot commented Jun 6, 2024

Hello @PieterCK!

Thanks for your interest in Zulip! You have attempted to claim an issue without the label "help wanted". You can only claim and submit pull requests for issues with the help wanted label.

If this is your first time here, we recommend reading our guide for new contributors before getting started.

@zulipbot
Copy link
Member

zulipbot commented Jun 6, 2024

Welcome to Zulip, @PieterCK! We just sent you an invite to collaborate on this repository at https://github.com/zulip/python-zulip-api/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip!

Here's some tips to get you off to a good start:

As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site.

See you on the other side (that is, the pull request side)!

PieterCK added a commit to PieterCK/python-zulip-api that referenced this issue Jun 7, 2024
@PieterCK
Slack bridge: Update Slack bridge with Events API.
d22ae40 
Currently we use the Slacks legacy RTM API as the
"listener" from Slack to Zulip. This commit replaces
RTM API for the supported Events API instead.

Fixes zulip#825.
@PieterCK PieterCK linked a pull request Jun 7, 2024 that will close this issue
Open
PieterCK added a commit to PieterCK/python-zulip-api that referenced this issue Jun 11, 2024
@PieterCK
slack bridge: Add legacy mode for Slack Bridge.
38e04b8 
Slack Bridge now uses the Slack Webhook integration
to get messages accross from Slack instead of the
legacy RTM API based connection our Slack Bridge
use.

This commit adds a "--legacy" argument to the script,
it acts as a toggle to run the RTM API based connection
to get messages accross to Zulip. It is used to ensure
backwards compitability for users who want to maintain
any ongoing Slack mirror.

Fixes zulip#825.
PieterCK added a commit to PieterCK/python-zulip-api that referenced this issue Jun 18, 2024
@PieterCK
slack bridge: Add legacy mode for Slack Bridge.
3d93bf2 
Slack Bridge now uses the Slack Webhook integration
to get messages accross from Slack instead of the
legacy RTM API based connection our Slack Bridge
use.

This commit adds a "--legacy" argument to the script,
it acts as a toggle to run the RTM API based connection
to get messages accross to Zulip. It is used to ensure
backwards compitability for users who want to maintain
any ongoing Slack mirror.

Fixes zulip#825.
PieterCK added a commit to PieterCK/python-zulip-api that referenced this issue Jun 22, 2024
@PieterCK
slack bridge: Add legacy mode for Slack Bridge.
34d88eb 
Slack Bridge now uses the Slack Webhook integration
to get messages accross from Slack instead of the
legacy RTM API based connection our Slack Bridge
use.

This commit adds a "--legacy" argument to the script,
it acts as a toggle to run the RTM API based connection
to get messages accross to Zulip. It is used to ensure
backwards compitability for users who want to maintain
any ongoing Slack mirror.

Fixes zulip#825.
PieterCK added a commit to PieterCK/python-zulip-api that referenced this issue Jun 22, 2024
@PieterCK
slack bridge: Add legacy mode for Slack Bridge.
5ae8f99 
Slack Bridge now uses the Slack Webhook integration
to get messages accross from Slack instead of the
legacy RTM API based connection our Slack Bridge
use.

This commit adds a "--legacy" argument to the script,
it acts as a toggle to run the RTM API based connection
to get messages accross to Zulip. It is used to ensure
backwards compitability for users who want to maintain
any ongoing Slack mirror.

Fixes zulip#825.
PieterCK added a commit to PieterCK/python-zulip-api that referenced this issue Jun 24, 2024
@PieterCK
slack bridge: Add legacy mode for Slack Bridge.
ed37167 
Slack Bridge now uses the Slack Webhook integration
to get messages accross from Slack instead of the
legacy RTM API based connection our Slack Bridge
use.

This commit adds a "--legacy" argument to the script,
it acts as a toggle to run the RTM API based connection
to get messages accross to Zulip. It is used to ensure
backwards compitability for users who want to maintain
any ongoing Slack mirror.

Fixes zulip#825.
PieterCK added a commit to PieterCK/python-zulip-api that referenced this issue Jun 28, 2024
@PieterCK
slack bridge: Add logic to prevent looping messages.
81ffb46 
When using Slack Webhook integration to get messages
from Slack to Zulip, we don't want to send back
messages from the Slack integration bot.

Fixes zulip#825.
PieterCK added a commit to PieterCK/python-zulip-api that referenced this issue Jun 29, 2024
@PieterCK
slack bridge: Add logic to prevent looping messages.
912fb72 
When using Slack Webhook integration to get messages
from Slack to Zulip, we don't want to send back
messages from the Slack integration bot.

Fixes zulip#825.
PieterCK added a commit to PieterCK/python-zulip-api that referenced this issue Jul 3, 2024
@PieterCK
slack bridge: Add logic to prevent looping messages.
4154470 
When using Slack Webhook integration to get messages
from Slack to Zulip, we don't want to send back
messages from the Slack integration bot.

Fixes zulip#825.
PieterCK added a commit to PieterCK/python-zulip-api that referenced this issue Oct 20, 2024
@PieterCK
slack bridge: Add logic to prevent looping messages.
be22bbe 
When using Slack Webhook integration to get messages
from Slack to Zulip, we don't want to send back
messages from the Slack integration bot.

Fixes zulip#825.
PieterCK added a commit to PieterCK/python-zulip-api that referenced this issue Oct 20, 2024
@PieterCK
slack bridge: Add logic to prevent looping messages.
18811b0 
When using Slack Webhook integration to get messages
from Slack to Zulip, we don't want to send back
messages from the Slack integration bot.

Fixes zulip#825.
PieterCK added a commit to PieterCK/python-zulip-api that referenced this issue Oct 20, 2024
@PieterCK
slack bridge: Add logic to prevent looping messages.
ea6923e 
When using Slack Webhook integration to get messages from Slack to
Zulip, we don't want to send back messages from the Slack integration
bot.

This prevents that by filtering out any messages from the Slack Webhook
bots when sending messages from Zulip to Slack..

Fixes zulip#825.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PieterCK PieterCK

Labels
help wanted in progress
Projects
Zulip release priorities
Status: No status
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Slack bridge: Update Slack bridge with Events API. PieterCK/python-zulip-api
2 participants
@zulipbot @PieterCK