Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USS Filetag is improperly changed to profile-encoding #2377

Closed
jHeidenberger opened this issue Jul 13, 2023 · 6 comments
Closed

USS Filetag is improperly changed to profile-encoding #2377

jHeidenberger opened this issue Jul 13, 2023 · 6 comments
Labels
bug Something isn't working priority-medium Not functioning - next quarter if capacity permits severity-medium Bug where workaround exists or that doesn't prevent the usage of Zowe. Just makes it more complex.
Milestone

Comments

@jHeidenberger
Copy link

Describe the bug

I recently (finally) upgraded from v1.8 to version v2.9.1. We work with rocket-git and different encoded uss files (utf-8, ibm-1047, ibm-1141, iso8859-1,...). In the V2 profile I have set "encoding": "1141". If I now e.g. change a utf-8 encoded file, the file tag is changed to IBM-1141 which is not correct and desired. Is there a way to work around changing the filetag? With v1.8 this was possible and the filetags were not changed.

The following options are set for uss:
_CEE_RUNOPTS=FILETAG(AUTOCVT,AUTOTAG) POSIX(ON)
_BPXK_AUTOCVT=ALL

To Reproduce

  • create a zosmf profile with "encoding: 1141".
  • open a utf-encoded uss file by double-clicking for this profile
  • change anything
  • save (ctrl-s) the file

Expected behavior

filetag is not changed and uss file is saved with the original filetag (e.g. utf8).

Screenshots

Desktop (please complete the following information):

  • OS: Windows 10 Enterprise 10H21, z/OS 2.5
  • Zowe Explorer Version: v2.9.1
  • (Optional) Zowe CLI Version: 7.1.3
  • (Optional) Are you using Secure Credential Store? no

Additional context

@jHeidenberger jHeidenberger added the bug Something isn't working label Jul 13, 2023
@github-actions
Copy link

Thank you for creating a bug report.
We will investigate the bug and evaluate its impact on the product.
If you haven't already, please ensure you have provided steps to reproduce the bug and as much context as possible.

@JTonda JTonda added priority-medium Not functioning - next quarter if capacity permits severity-medium Bug where workaround exists or that doesn't prevent the usage of Zowe. Just makes it more complex. labels Jul 18, 2023
@t1m0thyj
Copy link
Member

t1m0thyj commented Aug 3, 2023

This may be related to zowe/zowe-cli#1431

When a USS file upload operation is performed, if encoding is defined on a "zosmf" profile in zowe.config.json, then it will take precedence over whatever encoding the file is already tagged as.

We could add an option to the z/OS Files SDK to prioritize the file's tagged encoding over the encoding specified in a profile.

@jHeidenberger
Copy link
Author

Hello,

thank you for the answer. Your suggestion sounds good and would solve my problem.

@storgj
Copy link

storgj commented Oct 23, 2023

Hello,
I have also encountered this issue and agree that the desired behaviour should be that the existing tag takes precedence over anything set in the profile.
An option to specify encoding when creating a new USS file would be amazing, but should I open a separate issue for that? As I see it, the zowe cli option to specify the encoding in the profile is only really useful for MVS datasets, whereas I typically need to work with a range of encodings in USS files.

@JillieBeanSim
Copy link
Contributor

@t1m0thyj was this resolved with PR #2594?

@t1m0thyj
Copy link
Member

@t1m0thyj was this resolved with PR #2594?

Yes, this was resolved in that PR because the following line causes tagged encoding to override profile encoding.
https://github.com/zowe/vscode-extension-for-zowe/blob/f1130e7bc1e73773ca37487ff406e620fd5c2e08/packages/zowe-explorer/src/shared/utils.ts#L233

The behavior when saving changes to USS files should be fixed in the next ZE release 2.14.0. However, some actions still use the profile encoding like uploading a local file or copy/pasting files in the USS tree.

An option to specify encoding when creating a new USS file would be amazing, but should I open a separate issue for that?

@storgj Feel free to open a separate issue specifically for the "Create File" action.

@JillieBeanSim JillieBeanSim added this to the v2.14.0 milestone Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority-medium Not functioning - next quarter if capacity permits severity-medium Bug where workaround exists or that doesn't prevent the usage of Zowe. Just makes it more complex.
Projects
Status: Closed
Development

No branches or pull requests

5 participants