Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

File Not Found Messaging Inconsistent #95

Closed
dkelosky opened this issue Oct 29, 2018 · 4 comments · Fixed by #2078
Closed

File Not Found Messaging Inconsistent #95

dkelosky opened this issue Oct 29, 2018 · 4 comments · Fixed by #2078
Assignees
@ATorrise
Labels
bug Something isn't working priority-low Legit issue but cosmetic or nice-to-have severity-low Bug that makes the usage of the Zowe less convenient but doesn't impact key use cases v3 prospective changes for v3
Milestone
Zowe V3

Comments

@dkelosky
Copy link
Contributor

zowe files upload ftds local remote gives a message like:

Command Error:
Node.js File System API error

zowe jobs submit lf noexist

Unexpected Command Error:
Please review the message and stack below.
Contact the creator of handler:
"C:\Users\xxx\AppData\Roaming\npm\node_modules\@brightside\core\lib\zosjobs\
src\cli\submit\local-file/../Submit.shared.handler"
Message:
ENOENT: no such file or directory, open 'C:\Users\xxx\Work\Dev\node\doesnot\
exist'
Stack:
Error: ENOENT: no such file or directory, open 'C:\Users\xxx\Work\Dev\node\d

It seems one command uses fs.readFileSync directly and another uses a custom encapsulation of fs.readFileSync. It seems they should use the same encapsulation for consistent messaging, perhaps IO.readFileSync?
@dkelosky dkelosky added the bug Something isn't working label Oct 29, 2018
@ghost
Copy link

ghost commented Oct 29, 2018

Do we already have an IO.readFileSync in place for zowe-cli?

@dkelosky
Copy link
Contributor Author

It looks to be in imperative

@JTonda JTonda mentioned this issue Nov 5, 2018
Closed
@MarkAckert
Copy link
Member

Confirmed this still exists. The error message from the first command does show ENOENT so users can figure out what happened, but the formatting between the 2 command errors is different.

@MarkAckert MarkAckert added priority-low Legit issue but cosmetic or nice-to-have for-review To be reviewed in an Eng & Prod Mgmt meeting labels Sep 29, 2022
@JTonda JTonda added severity-low Bug that makes the usage of the Zowe less convenient but doesn't impact key use cases and removed for-review To be reviewed in an Eng & Prod Mgmt meeting labels Apr 10, 2023
@ATorrise ATorrise added the v3 prospective changes for v3 label Aug 3, 2023
@ATorrise ATorrise added this to the Zowe V3 milestone Aug 3, 2023
@ATorrise ATorrise self-assigned this Feb 20, 2024
@ATorrise ATorrise linked a pull request Feb 22, 2024 that will close this issue
standardizing error handling #2062
Closed
4 tasks
@ATorrise ATorrise linked a pull request Mar 7, 2024 that will close this issue
Fnf error reporting #2078
Merged
4 tasks
@ATorrise
Copy link
Contributor

This issue has been addressed with #2078

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ATorrise ATorrise

Labels
bug Something isn't working priority-low Legit issue but cosmetic or nice-to-have severity-low Bug that makes the usage of the Zowe less convenient but doesn't impact key use cases v3 prospective changes for v3
Projects
Zowe CLI Squad
Status: Closed
Milestone
Zowe V3
Development

Successfully merging a pull request may close this issue.

Fnf error reporting zowe/zowe-cli
standardizing error handling zowe/zowe-cli
4 participants
@dkelosky @MarkAckert @JTonda @ATorrise