From 77dda1b955fb13d3a7a1ff712aa580cbc5ec664e Mon Sep 17 00:00:00 2001 From: Timothy Johnson Date: Thu, 26 Sep 2024 16:01:10 -0400 Subject: [PATCH] Remove Secrets SDK requirement when Imperative is a bundled dep Signed-off-by: Timothy Johnson --- packages/imperative/CHANGELOG.md | 4 ++++ packages/imperative/src/config/src/ConvertV1Profiles.ts | 2 +- .../imperative/src/security/src/DefaultCredentialManager.ts | 2 +- 3 files changed, 6 insertions(+), 2 deletions(-) diff --git a/packages/imperative/CHANGELOG.md b/packages/imperative/CHANGELOG.md index 357a55819b..87cb2bb7a2 100644 --- a/packages/imperative/CHANGELOG.md +++ b/packages/imperative/CHANGELOG.md @@ -2,6 +2,10 @@ All notable changes to the Imperative package will be documented in this file. +## Recent Changes + +- BugFix: Removed Secrets SDK requirement when Imperative is a bundled dependency. [#2276](https://github.com/zowe/zowe-cli/issues/2276) + ## `8.0.0` - MAJOR: v8.0.0 Release diff --git a/packages/imperative/src/config/src/ConvertV1Profiles.ts b/packages/imperative/src/config/src/ConvertV1Profiles.ts index 4669d2f8dd..7fcc7e1bd5 100644 --- a/packages/imperative/src/config/src/ConvertV1Profiles.ts +++ b/packages/imperative/src/config/src/ConvertV1Profiles.ts @@ -20,7 +20,7 @@ import { IConfig } from "./doc/IConfig"; import { CredentialManagerFactory } from "../../security"; import { IConvertV1ProfOpts, ConvertMsg, ConvertMsgFmt, IConvertV1ProfResult } from "./doc/IConvertV1Profiles"; import { IImperativeOverrides } from "../../imperative/src/doc/IImperativeOverrides"; -import { keyring } from "@zowe/secrets-for-zowe-sdk"; +import type { keyring } from "@zowe/secrets-for-zowe-sdk"; import { AppSettings } from "../../settings"; import { ISettingsFile } from "../../settings/src/doc/ISettingsFile"; import { ImperativeConfig } from "../../utilities"; diff --git a/packages/imperative/src/security/src/DefaultCredentialManager.ts b/packages/imperative/src/security/src/DefaultCredentialManager.ts index a89669c448..23b1da384d 100644 --- a/packages/imperative/src/security/src/DefaultCredentialManager.ts +++ b/packages/imperative/src/security/src/DefaultCredentialManager.ts @@ -13,7 +13,7 @@ import { AbstractCredentialManager, SecureCredential } from "./abstract/Abstract import { ImperativeError } from "../../error"; import { Logger } from "../../logger"; -import { keyring as keytar } from "@zowe/secrets-for-zowe-sdk"; // Used for typing purposes only +import type { keyring as keytar } from "@zowe/secrets-for-zowe-sdk"; // Used for typing purposes only /** * Default Credential Manager is our implementation of the Imperative Credential Manager. This manager invokes methods