-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align docutils version with sphinx_rtd_theme requirement #1220
Comments
@stevepiercy From what I see here, Zope's constraint for docutils ( The problem is that zest.releaser pulls in readme-renderer, and readme-renderer 0.44 requires One way to resolve this would be to pin readme-renderer to an older version that still supports docutils 0.18. Another way would be to add support for docutils 0.21.2 in sphinx_rtd_theme, and then update or remove the docutils pin here. |
That's my preferred option, and I expect it will happen soon. See the linked PR in this issue description. I would prefer the removal of the pin from Zope, but maybe there is a valid reason to pin it similar to |
We pin all dependencies here, so a pin will stay. We can update it, sure. |
Just noticed that there is no newer |
I subscribed to notifications when that PR readthedocs/sphinx_rtd_theme#1576 is merged and when |
Alternatively to waiting for
Sphinx 8 was released last week: https://www.sphinx-doc.org/en/master/changes/8.0.html |
See #1221 for a suggestion using |
I have merged #1221 and the result is visible at https://zope.readthedocs.io/en/latest/index.html. It's a nice clean look and the dependencies are cleaned up. |
I really like, how it looks now. Thank you! |
yes it looks nice now. But could we include the Zope Logo in the Docs. @icemac would that also be a good theme for other Zope Projects like RestrictedPython? |
For the logo, see Adding a logo |
I have added the logo and also tweaked the blue link color to match the logo's blue color. That only looks well in the dark theme, so the light theme retains the default link color.
Yes of course. |
With the upcoming release of
sphinx_rtd_theme
3.0, docutils will get bumped to the following:Should we remove the docutils pin in
versions.cfg
and allowsphinx_rtd_theme
to handle its installation, or should we bump accordingly?FTR, I ran into a version conflict when trying to install
plone.restapi
with buildout, and it took me a while to hunt down where it fell down:The text was updated successfully, but these errors were encountered: