Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NPM builds: allow for legacy peer dependencies #32

Open
eatyourgreens opened this issue Oct 3, 2022 · 2 comments · May be fixed by #33
Open

NPM builds: allow for legacy peer dependencies #32

eatyourgreens opened this issue Oct 3, 2022 · 2 comments · May be fixed by #33

Comments

@eatyourgreens
Copy link
Contributor

ci-cd/.github/workflows/npm_build.yaml

Line 39 in 34dabfb

- run: npm ci

PFE is now so old that it must be installed with npm ci --legacy-peer-deps. Otherwise, Node installs fail here with an unmatched peer dependencies error in older packages.
@eatyourgreens
Copy link
Contributor Author

One solution might be to be to use .npmrc to override the install flags, in which case the workflow doesn't need to be updated.

@eatyourgreens
Copy link
Contributor Author

eatyourgreens commented Oct 3, 2022 •
edited
Loading

I've updated PFE to set legacy-peer-deps in .npmrc.

  • Pro's: no changes to the workflow here.
  • Con's: CLI flags for builds are in a hidden file, so might be missed by anyone trying to follow the deploy workflows.

https://github.com/zooniverse/Panoptes-Front-End/blob/1748e273c69bdfa9f8716998260d5f6af8c48836/.npmrc#L1-L2

@camallen camallen linked a pull request Oct 5, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add ci_args to npm ci run cmd zooniverse/ci-cd
1 participant
@eatyourgreens