Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New batch id format #1154

Open
mattias-p opened this issue Feb 9, 2024 · 0 comments
Open

New batch id format #1154

mattias-p opened this issue Feb 9, 2024 · 0 comments

Comments

@mattias-p
Copy link
Member

mattias-p commented Feb 9, 2024

Historically the batch feature was intended for strictly internal use but this changes with #1153. Today the format of the batch id is just an integer and new batch ids are generated using a counter. We should introduce a new batch id format to be used in the new API. The new format should use some kind of tokens similar to job ids. It would probabaly be nice if its easy to distinguish between a job id and a batch id.

  • Update batch_create to return batch ids in the new format,
  • update get_batch_job_result, batch_status, batch_results and batch_domains to accept batch ids in both the old and the new formats.

Once add_batch_job is removed we should also migrate all existing batches using the old batch id format to new ids in the new format.

Stabilization

Tracking issue

Affected interfaces

Incompatibly changed:

  • batch_create

Compatibly changed:

  • get_batch_job_result
  • batch_status
  • batch_results
  • batch_domains

Dependencies

None

Overlapping proposals

None

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant