Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify get_dataset signature? #112

Open
ablot opened this issue Jul 17, 2023 · 1 comment
Open

simplify get_dataset signature? #112

ablot opened this issue Jul 17, 2023 · 1 comment

Comments

@ablot
Copy link
Member

ablot commented Jul 17, 2023

def get_datasets(

To merge all existing options get_datasets ended up having a bit of a weird signature with return_paths and return_dataseries flags.
The behaviour when both flags are True is return_dataseries and return_dataseries is actually returning a dataframe if allow_multiple if True.

Should we change that or is that fine?

@znamensk
Copy link
Member

Should we just keep return_paths with a default of False and return a Dataframe if it's not set?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants