Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docstring would be lovely #5

Open
erhant opened this issue May 22, 2024 · 2 comments
Open

Docstring would be lovely #5

erhant opened this issue May 22, 2024 · 2 comments

Comments

@erhant
Copy link
Contributor

erhant commented May 22, 2024

Since the types are rather fancy throughout the exported items, hovering over them alone does not help too much to understand their usage. I presume some level of WASM-literacy is expected from the user, but in any case I think docstrings would be so much helpful.

@erhant
Copy link
Contributor Author

erhant commented May 24, 2024

@mitschabaude if you can point me to some docs that are kind of 1-to-1 with the naming, I can work on the docs as well. I have a fetish of writing docs hahah & it would personally help me learn quite a lot; in case you have work to do elsewhere right now 🙏🏻

@mitschabaude
Copy link
Member

@erhant sorry for replying so late.

Obviously docstrings would be awesome, but also a considerable undertaking that I don't have the time for currently.

Regarding resources, I was working mostly off of the Webassembly spec: https://webassembly.github.io/spec/core/

Note that for implementing wasmati it was not necessary to understand what all individual instructions actually do 😅 We just need to provide an interface with the correct input/output type, and support encoding all instructions into wasm bytecode.

Incomplete docs for some instructions can be found on MDN: https://developer.mozilla.org/en-US/docs/WebAssembly/Reference

To actually understand some of the newer instructions however, the only useful docs I found were often the original Wasm extension proposals, for example this one for SIMD

An invaluable resource to see all old and new extensions is the WebAssembly Roadmap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants