Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properties::parse_from_xml_reader should take Read instead of BufRead #3

Open
mainrs opened this issue Jan 30, 2021 · 0 comments
Open

Comments

@mainrs
Copy link

mainrs commented Jan 30, 2021

This makes the method more generic. If a BufReader is needed due to internal implementation, I think it's a better idea to create that inside of the function instead of having the user have to create one themselves.

I'm open to implementing this if you're OK with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant