Use of log.Fatal causes upstream application to exit

[jrschumacher]

The use of log.Fatal causes the upstream application to exit.

oidc/pkg/http/http.go

Lines 95 to 112 in c3c1bd3

	func StartServer(ctx context.Context, port string) {
	server := &http.Server{Addr: port}
	go func() {
	if err := server.ListenAndServe(); err != http.ErrServerClosed {
	log.Fatalf("ListenAndServe(): %v", err)
	}
	}()
	go func() {
	<-ctx.Done()
	ctxShutdown, cancelShutdown := context.WithTimeout(context.Background(), 5*time.Second)
	defer cancelShutdown()
	err := server.Shutdown(ctxShutdown)
	if err != nil {
	log.Fatalf("Shutdown(): %v", err)
	}
	}()
	}

Is there a reason why we don't want to return an error and/or the shutdown function and expect developers to implement the go-routine to shutdown appropriately?

log.Fatal will kill the process even in goroutines https://go.dev/play/p/Hy6rKkePzJY

[muhlemmer]

Can you be specific about which log.Fatal use is bugging you?

[jrschumacher]

@muhlemmer my bad I posted the missing permalink in the original message