Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clearfix display:table affecting actual elements with class name #4

Open
kennasoft opened this issue Mar 6, 2017 · 2 comments
Open

Clearfix display:table affecting actual elements with class name #4

kennasoft opened this issue Mar 6, 2017 · 2 comments

Comments

@kennasoft
Copy link

On line 166 of grid.css.less, you should delete the .clearfix, there, as the expected behaviour of clearfix is meant to affect the :before and :after pseudo-elements and not the element itself.
@zirafa
Copy link
Owner

zirafa commented Mar 17, 2017

Hm...that makes sense. Does it cause any problems? I can't recall if that was in the original Bootstrap files. Feel free to submit a PR for review.

@kennasoft
Copy link
Author

Sorry I left this open for so long. I submitted a PR for your review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zirafa @kennasoft