-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding metrics #53
Comments
cc @toxicafunk |
I just migrated zio-metrics to the new org and successfully builded on circleci: https://circleci.com/gh/zio/zio-metrics It should be ready minus bugs that may be encountered during usage. I am currently writing an implementation that creates an ZEnv for Prometheus and for Dropwizard but the current version should be usable. Will ask on the channel on how to publish it and I'm more than willing to work integrating it here. |
@toxicafunk do you need any help? Do you plan to add tracing ? |
@toxicafunk let us know if you need any help. @pshemass I'm not sure about tracing. There are plenty of options for Open Tracing out there, and it's relatively simple to "bake" another, ZIO compatible client. However, Open Telemetry looks more interesting to me. I think it's worth jumping in that train. However, at the moment I don't think we should broaden the scope too much. Let's come up with the set of metrics we want to expose, and see whether |
no, we should not blow the scope now, I'm just curious. |
|
@toxicafunk I agree with the point 4. Also, we should take a look at edit: Not sure whether it makes sense, just a wild guess :) |
So you can see my test for Prometheus here: https://github.com/toxicafunk/zio-tests/blob/prometheus/src/main/scala/com/richweb/Main.scala on the main function you'll see I define the backend impl:
and since my own reporters are.... "funny".... I just use the Http Server included in Prometheus
which produces the following output given the counter
The count is correct since my file has 100k messages and we can average (sum/count) that processing took 24.56 ms/message. For DropWizard (https://github.com/toxicafunk/zio-tests/blob/dropwizard/src/main/scala/com/richweb/Main.scala) I just define its backend:
The easiest reporter to set is the ConsoleReporter:
You may observe defining the count and timer (or its usage) doesn't change:
which produces the following output:
So the library is usable but does needs some care and love 😄 Any comments? |
I have opportunity to test at work because we have Kamon setup with Prometheus. API is usable but it needs some love :) Is there zio-metrics gitter channel that could discuss this? |
There is now: https://gitter.im/ZIO/zio-metrics |
Just wanted to add that there is also a
|
one of most important part of distributed system is observability that's why we should build our library with this mindset.
Probably we should try to use https://github.com/zio/zio-metrics if it is not ready we should join them to help them release it.
@jdegoes @mijicd Let me know if you see other options.
The text was updated successfully, but these errors were encountered: