Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor control stack to support complex control flow #287

Open
clearloop opened this issue Nov 29, 2024 · 2 comments
Open

Refactor control stack to support complex control flow #287

clearloop opened this issue Nov 29, 2024 · 2 comments
Assignees
Labels
budget-$150 Payable large onboarding issues bug Something isn't working refactor This issue requires a refactor to the design

Comments

@clearloop
Copy link
Member

clearloop commented Nov 29, 2024

when we have return logic which is not at the end of function, it could be trigged incorrectly since the jump target for the end of the control frame is not correctly calculated, see the details at https://github.com/zink-lang/zink/blob/main/examples/br_balance.rs#L17

this could be the last fragment to ERC20

@clearloop clearloop added bug Something isn't working refactor This issue requires a refactor to the design labels Nov 29, 2024
@clearloop clearloop added the budget-$150 Payable large onboarding issues label Nov 30, 2024
@malik672
Copy link
Contributor

malik672 commented Dec 2, 2024

@clearloop assign me

@clearloop
Copy link
Member Author

clearloop commented Dec 3, 2024

@clearloop assign me

this is actually a pretty hard debugging task, lines need to be changed may be minor but each lines we change could have lots of side effects, especially, you need to debug the output bytecode byte by byte and run tests locally to verify your implementations yourself but not like what we did in #292, leaves a broken CI then expect me to point out the problem ))

however this is also the kind of problem that AI helps a lot! anyway, will temporarily assign you, feel free to try it out! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
budget-$150 Payable large onboarding issues bug Something isn't working refactor This issue requires a refactor to the design
Projects
Status: No status
Development

No branches or pull requests

2 participants