Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support struct as function parameters #261

Open
clearloop opened this issue Oct 31, 2024 · 3 comments
Open

Support struct as function parameters #261

clearloop opened this issue Oct 31, 2024 · 3 comments
Labels
budget-$100 Payable medium onboarding issues

Comments

@clearloop
Copy link
Member

clearloop commented Oct 31, 2024

Describe the feature

similar to the support of dynamic arguments

Solution

need to calculate the length of struct in compilation from function signatures

@clearloop clearloop added budget-$50 Payable small onboarding issues budget-$100 Payable medium onboarding issues and removed budget-$50 Payable small onboarding issues labels Nov 26, 2024
@malik672
Copy link
Contributor

@clearloop currently working on this, I don't think I understand this fully lol

@clearloop
Copy link
Member Author

clearloop commented Nov 27, 2024

@clearloop currently working on this, I don't think I understand this fully lol

Thank you for your contribution!

This issue requires some pre-requirements, for example the support of #253 which is pretty complex in the memory model, if you'd like to dive into the memory model, I'd suggest to try #249 if you understand the dynamic memory in solidity correctly! you can imagine that excepting the basic opcode mappings, zink is like a HUFF library ^ ^

btw, I hope you can focus on the issues assigned to you previously first )) once you complete #255 and #256, it will be easy for you to handle all of the derived macro related stuffs in zink, it's a huge part indeed ))

feel free to chat about anything related in our telegram group!

@malik672
Copy link
Contributor

@clearloop currently working on this, I don't think I understand this fully lol

Thank you for your contribution!

This issue requires some pre-requirements, for example the support of #253 which is pretty complex in the memory model, if you'd like to dive into the memory model, I'd suggest to try #249 if you understand the dynamic memory in solidity correctly! you can imagine that excepting the basic opcode mappings, zink is like a HUFF library ^ ^

btw, I hope you can focus on the issues assigned to you previously first )) once you complete #255 and #256, it will be easy for you to handle all of the derived macro related stuffs in zink, it's a huge part indeed ))

feel free to chat about anything related in our telegram group!

will leave it then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
budget-$100 Payable medium onboarding issues
Projects
Status: No status
Development

No branches or pull requests

2 participants