Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zingo cannot correctly compute fee amounts for transactions containing outputs it can't recover. #1036

Open
nuttycom opened this issue May 7, 2024 · 0 comments

Comments

@nuttycom
Copy link

nuttycom commented May 7, 2024

In

let outputted = self.value_outgoing() + self.total_change_returned();
, Zingo uses its knowledge of transaction outputs to compute the fee paid. However, this is insufficient; it needs to instead compute the difference using the transparent value of inputs and outputs, along with the valueBalance fields for each shielded pool. Otherwise, transactions that use OVKs that prevent output recovery by the originating wallet will show the balance of the transaction going to fee, and currently outputs to wallet-internal keys are also treated in this fashion, with the value appearing to go to fee instead of the wallet or an unknown recipient.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant