Skip to content

Commit 01cc637

Browse files
authored
Correctly handle ices in metal chemistry (AMReX-Astro#1650)
Minor modifications to ensure we handle ices correctly in the metal chemistry network (following the methodology used in KROME - Grassi et al. 2014). Also updates the reference solution outputs (minor differences from what we already have).
1 parent 1e1dc14 commit 01cc637

11 files changed

+800
-798
lines changed

.github/workflows/burn_cell_metal_chem.yml

+5-3
Original file line numberDiff line numberDiff line change
@@ -39,14 +39,14 @@ jobs:
3939
cd unit_test/burn_cell_metal_chem
4040
4141
declare -A line_numbers_map=(
42-
["Z=1"]="4461 4463 4465 4467 4468 4471 4472 4475 4481 4486"
42+
["Z=1"]="4450 4452 4454 4456 4457 4460 4461 4464 4470 4475"
4343
["Z=1_z10"]="1613 1615 4456 4458 4460 4463 4470 4476 4481"
4444
["Z=1e-1"]="4438 4440 4442 4444 4445 4448 4449 4452 4458 4463"
4545
["Z=1e-2"]="4438 4440 4442 4444 4445 4448 4449 4452 4458 4463"
4646
["Z=1e-3"]="4438 4440 4442 4444 4445 4448 4449 4452 4458 4463"
4747
["Z=1e-4"]="4438 4440 4442 4444 4445 4448 4449 4452 4458 4463"
4848
["Z=1e-5"]="4438 4440 4442 4444 4445 4448 4449 4452 4458 4463"
49-
["Z=1e-6"]="4438 4440 4442 4444 4445 4448 4449 4452 4458 4463"
49+
["Z=1e-6"]="4451 4453 4455 4457 4458 4461 4462 4465 4471 4476"
5050
)
5151
5252
declare -A ref_map=(
@@ -92,9 +92,11 @@ jobs:
9292
9393
# Adjust the line number for the reference file
9494
if [[ "$Z" == "Z=1" ]]; then
95-
reference_line_number=$((line_number - 4460))
95+
reference_line_number=$((line_number - 4449))
9696
elif [[ "$Z" == "Z=1_z10" ]]; then
9797
reference_line_number=${ref_line_number_z10[$index]}
98+
elif [[ "$Z" == "Z=1e-6" ]]; then
99+
reference_line_number=$((line_number - 4450))
98100
else
99101
reference_line_number=$((line_number - 4437))
100102
fi

EOS/metal_chem/_parameters

+2-2
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,11 @@
33
eos_gamma_default real 1.4
44

55
# define the specie names, and their masses and gammas
6-
species_1_name string "co_ice"
6+
species_1_name string "co_total"
77
species_1_gamma real 5./3.
88
species_1_mass real 0.0
99

10-
species_2_name string "h2o_ice"
10+
species_2_name string "h2o_total"
1111
species_2_gamma real 5./3.
1212
species_2_mass real 0.0
1313

0 commit comments

Comments
 (0)