Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support setting the security context and pod topology spread constraints for Milvus components #144

Open
bcbrockway opened this issue Jul 1, 2024 · 4 comments
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone

Comments

@bcbrockway
Copy link

bcbrockway commented Jul 1, 2024

For security reasons, we use Kyverno's admission controller on our cluster to ensure that certain Linux capabilities are dropped and that containers run as non-root, along with other policies. While we can change the security contexts of the components using the Bitnami Helm charts (etcd, Kafka, etc.) we are unable to do this for MinIO and the Milvus components.

In addition, in order to improve resiliency, we would like to be able to set Pod Topology Spread Constraints for the same components.

This is a feature request to expose these through the Milvus CRD.

@haorenfsa
Copy link
Collaborator

In milvus-operator we can support this for Milvus components.
By default milvus-operator uses minio chart in https://github.com/zilliztech/milvus-helm/tree/master/charts/minio. So we also need a patch for milvus-helm. Or does bitnami provide a helm chart for MinIO, too?

@haorenfsa haorenfsa added the enhancement New feature or request label Jul 1, 2024
@bcbrockway
Copy link
Author

does bitnami provide a helm chart for MinIO, too?

Looks like it: https://github.com/bitnami/charts/tree/main/bitnami/minio. Was there not a specific reason for using your own one?

@haorenfsa
Copy link
Collaborator

Hi @bcbrockway, I just talked a previous maintainer. There're some bug fixes added to this chart , that're not merged by bitnami at that time, so they decided to maintain a fork by themselves.

@bcbrockway bcbrockway changed the title Support setting the security context for MinIO and Milvus components Support setting the security context and pod topology spread constraints for MinIO and Milvus components Jul 4, 2024
@bcbrockway
Copy link
Author

Thanks @haorenfsa. Should I raise an issue there for the MinIO changes?

Also, FYI, I also added Pod Topology Spread Constraints as a request to this ticket since it's a very similar type of change for the same components.

@haorenfsa haorenfsa added the good first issue Good for newcomers label Jul 4, 2024
@bcbrockway bcbrockway changed the title Support setting the security context and pod topology spread constraints for MinIO and Milvus components Support setting the security context and pod topology spread constraints for Milvus components Jul 12, 2024
@haorenfsa haorenfsa added this to the v1.2.0 milestone Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants