Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Headless Services for milvus proxy? #137

Open
qchenzi opened this issue Jun 25, 2024 · 4 comments
Open

Support Headless Services for milvus proxy? #137

qchenzi opened this issue Jun 25, 2024 · 4 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@qchenzi
Copy link

qchenzi commented Jun 25, 2024

Hi everyone,

I have noticed that the current implementation of the Milvus Operator does not support headless services. Headless services are essential for certain stateful applications that require direct access to individual pods without load balancing.

image

From the above, we can see that my-release-milvus does not have a ClusterIP as a headless service for nodes.
Could you please confirm if there are any plans to add support for headless services in the Milvus Operator?

Thank you for your attention to this matter.

@qchenzi
Copy link
Author

qchenzi commented Jun 25, 2024

Hi @haorenfsa

I have submitted a pull request that addresses this functionality. #138
After implementing the changes, can be seen as shown in the attached image:
image

Please review the pull request at your earliest convenience. I am open to any feedback or suggestions for improvement.

Best regards

@haorenfsa
Copy link
Collaborator

Hi @qchenzi, thank you for bring this out. My question is the proxies of Milvus are considered stateless. There seems no need for headless service. Could you describe your specific case when headless service is needed?

@qchenzi
Copy link
Author

qchenzi commented Jun 25, 2024

Hi @haorenfsa ,

Thank you for your response and for considering the pull request. In our specific case, We are using CoreDNS to configure wildcard DNS entries to dynamically resolve the IPs of the pods. This setup is essential for our internal service discovery and communication needs, where each pod needs to be accessible individually by a predictable DNS name.

While Milvus proxies are stateless, enabling headless services provides significant operational benefits for our specific use case.

@haorenfsa
Copy link
Collaborator

OK. That make sense to me

@haorenfsa haorenfsa added enhancement New feature or request good first issue Good for newcomers labels Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants