Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to config rollingUpdate strategy #112

Open
douglarek opened this issue May 8, 2024 · 3 comments
Open

How to config rollingUpdate strategy #112

douglarek opened this issue May 8, 2024 · 3 comments
Labels
enhancement New feature or request
Milestone

Comments

@douglarek
Copy link

Is there a way to configure the rollingUpdate strategy for the querynode deployment separately in the milvus-operator? In cases where there are a large number of queryNode pods with high memory usage, a maxSurge of 25% causes significant resource fluctuations in the cluster.

@douglarek
Copy link
Author

Is there a way to configure the rollingUpdate strategy for the querynode deployment separately in the milvus-operator? In cases where there are a large number of queryNode pods with high memory usage, a maxSurge of 25% causes significant resource fluctuations in the cluster.

default settings in queryNode deployment:

strategy:
  rollingUpdate:
    maxSurge: 25%
    maxUnavailable: 0
  type: RollingUpdate

@douglarek
Copy link
Author

I noticed that in commit 242f4d4 of version 0.9, it was changed to a more conservative 1. Can this parameter be exposed later?

@haorenfsa
Copy link
Collaborator

@douglarek No for now, but maybe yes in Milvus v2.4 or v2.5. That's mainly because the k8s deployment controller won't respect the terminating pods when rolling kubernetes/kubernetes#107920, which is crucial for the rolling progress of Milvus.
Please note that milvus-operator now uses 2 deployment for rolling. So the normal strategy for deployment won't work. The @zilliztech/milvus team insists on keep rolling 1 at a time for the time being in order to ensure the availability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants