Replies: 36 comments 117 replies
-
I was patching ZHA and adding the part for using presets by appending this in the end of https://github.com/home-assistant/core/blob/dev/homeassistant/components/zha/climate.py
with 2 blank line before and no after. The schedule mode shall being exposed and used for enable / disable schedule automation. I think this is good implementation for other TRVs that s not having implanting more the on / off. |
Beta Was this translation helpful? Give feedback.
-
The Quirk is in place but its looks its only working one way (only updated Siterwell part):
Then changing mode in ZHA i getting in the log:
that is the command from ZHA to the quirk and then the quirk is sending mode change to the TRV (normal 2-5 times then not getting and replay from the TRV) and its changing mode and reporting all new attribute to ZHA that is updating it = all is OK. Then changing mode on the TRV or with cluster commands (attribute 0x0404) the TRV is doing all the changed and ZHA is getting it but not the preset change is sent on attribute 0x4000 from the quirk so ZHA it staying in the last selected mode (can being Schedule mode with all TRV attribute from Away mode). So the command from the TRV is not triggering one mode change on attribute 0x4000 but all other is updated. I like that is working both ways so the user can see what mode the TRV is in if is changed from ZHA or local. If ZHA is not getting the updated mode from the TRV and some changing it local then the automation is not working OK. I letting it over the night and see if i can finding somthing. |
Beta Was this translation helpful? Give feedback.
-
Updated Quirk that working in both ways then changing working mode (presets in ZHA):
And the updated device classe:
I have only changing the type 1 but if you is having one type 2 make the same changes doe that device class and it shall working. The Great thanks to @jacekk015 that have making one working code that i have steeling !! For user of this TRV and its mode / presets in ZHA:This TRV is not having any off mode and is always in heating mode but can being sett in away mode (= idle with anti freeze) and its the right way for TRVs (stop and go is for cars !!). If you like doing automatons for Schedule changes of the setpoint temperature you shall using the presets |
Beta Was this translation helpful? Give feedback.
-
You don't need that part:
|
Beta Was this translation helpful? Give feedback.
-
Latest status of changes implanted:Future changes implanted for the TRV:
Missing upcoming futures for the TRV:
Away mode is showing idle in ZHA without setpoint temperature but it can being set on the TRV or by cluster attribute. All good new code is steeled from @jacekk015 and patched with "cut and paste". |
Beta Was this translation helpful? Give feedback.
-
Then doing the changes in the quirk its braking the tuya test and i cant fixing that code then its over my head :-(( If like to testing or using it you need adding the follow code in the end of
Its working great for my but i cant doing more at the moment for getting all functionality in our devices :(( |
Beta Was this translation helpful? Give feedback.
-
Was looking little and if using the automation in HAs climate component and is one very nice schedule custom component that is like many user have starting using. |
Beta Was this translation helpful? Give feedback.
-
@MattWestb Let's take your Siterwell on the work. You have some attributes documented above. But even that please share the log from reset or re-add of the device to the ZHA. |
Beta Was this translation helpful? Give feedback.
-
Device signature:
Battery out and in:
I think i have not deleting all handles from some steeled code that is not working OK and getting errors :-( |
Beta Was this translation helpful? Give feedback.
-
You have Window detect enabled?? Or [1] means disabled, [0] enabled
Valve detect switch - what does it mean? What does it do or show? Heating???
How does this work?? Alarm comes after some time or how?? This file shows 8 attributes your 1 post shows 9 attributes Your post is missing: You show this attributes, and they not: Besides, if you switch to Schedule, Manual modes does target temperature is always at the same attribute?? Are there any other attributes? What about Away mode??? I don't see nothing. |
Beta Was this translation helpful? Give feedback.
-
Window detection 0 = disabled (no window in the display) 1 = enabled (Window in the display) The original implementation was having valve state and temperature calibration but its not implanted in the device (what i knowing) so i have deleting them in my version but they is in the normal ZHA quirk. The "alarms" i have only implanted from the device and not to ZHA then i was not finding one working way to do that (until yesterday evening) so not expose in ZHA but like to have. The device is only using one setpoint temperature but is remember it then changing mode. I think you shall see this TRV as one local working TRV that is getting extra functions from the host system like Schedule can being sent in one automation and enabling it if the TRV is in Schedule mode and then sending new setpoints to the TRV on times you have defined in your automation. Draw back of the TRV is no valve state (opening %) reported and no calibration = can getting the device reporting often then every 55 minutes if not sending new setpoint or changing mode. Good on the device is good working basic functions and if not making some strange automatons all can being done easy on the device (not the valve detect) and working if your host system is offline. Missing future in ZHA: Switch for window open on / off and valve detect. The rest is working OK but perhaps not good coded then i have copy adapting some without knowing how its working. One thing is if restarting HA the presets is not real remember of ZHA and is showing "none" until changing mode on the device or in ZHA then its being in sync. I hope i have explaining all right but asking if its somthing you need getting cleared. |
Beta Was this translation helpful? Give feedback.
-
@MattWestb Check the attached quirk. Best would be to re-add the device to ZHA. One thing to clarify.
because I see that the code sets the Heat/Idle states using that attribute
for my TRV I've cheated a little bit. GUI shows Heat when target temp > room temp. |
Beta Was this translation helpful? Give feedback.
-
My mistake. Copy&paste needs more attention. |
Beta Was this translation helpful? Give feedback.
-
I have one more Principe question. I think both is ways is OK, i only dont like the Sass is having one other that is not like the "normal" ones but its (or shall) not our problem for the moment. |
Beta Was this translation helpful? Give feedback.
-
Testing TRV functions for getting the right sensor named.Siterwell have window open and valve jammed alarms that can being activated or not. For getting the TRV failing valve detecting is easiest having the valve on the table and putting the setpoing some degree over its measured one so it start working and waiting for the temperature rising that is not doing. After some time its giving up and you is getting one @jacekk015 was testing the Window open by putting one TRV outside but it was not working OK and putting it the freezer it was trigger the function and sending the attribute. On thing is if the temperature is not falling fast enough the window open is not being triggered but is looks then its coming later as one antifreeze alarm then the temperature is coming around 5° C if lowering slowly in my first experiment. |
Beta Was this translation helpful? Give feedback.
-
Temp calibration repaired - I've forgot that bus returns List, not value Give me long time DEBUG logs from the moment before switch enabled to enabling and disabling time. |
Beta Was this translation helpful? Give feedback.
-
Debug looks working OK now.
I think its not possible tricking the Site TRVs but i think its not one large problem they is reporting every 55 min (or it was 60) and if the temperature is changing one °. |
Beta Was this translation helpful? Give feedback.
-
@MattWestb Here's updated file for Siterwell |
Beta Was this translation helpful? Give feedback.
-
@PLTorrent Here is my brainstorming for getting better support of Siterwell TRVs that is having not so much function but most is broken in the original commit but is working very well with little coding and brain from jacekk015. |
Beta Was this translation helpful? Give feedback.
-
@jacekk015 Its looks like then changing the setpoint in ZHA GUI somthing is going wrong and some time ZHA is being in one lock state and its not possible changing the temperature (the new temp is being red for some seconds and going back to the old one) and getting this in this error in the HA log:
Its look like the loop is getting wrong value types and is stopping. Thanks in advance !! |
Beta Was this translation helpful? Give feedback.
-
Hey @jacekk015 I was trying converting the But then deleting and adding the TRV with the updated and not updated quirk is the TRV card only showing setpoint temperature and no local temprature. Was trying adding the presets in the Thanks in advance for great help !! |
Beta Was this translation helpful? Give feedback.
-
Updated Quirk and One side effect is the climate is throng one error then setting away mode if having the GUI for it open.
|
Beta Was this translation helpful? Give feedback.
-
What function is missing? |
Beta Was this translation helpful? Give feedback.
-
HA 2023.1.2 is braking one more function and ZHA is not starting:
|
Beta Was this translation helpful? Give feedback.
-
Updated Quirk and climate patched for working with HA 2023.1.2 that have some braking changes. |
Beta Was this translation helpful? Give feedback.
-
Quirk corrected |
Beta Was this translation helpful? Give feedback.
-
Thanks for that explaination. I have a couple other questions. Child Lock And finally, in the sensors section, I have three sensors, two are simply labelled 'binaryinput' with a value of off, and the last is HVAC Action. Any thoughts on what the first two are ? |
Beta Was this translation helpful? Give feedback.
-
Switches:
Sensors:
|
Beta Was this translation helpful? Give feedback.
-
Why this quirk is not published in repo ? i am unable to found Siterwell folder in zha-device-handlers |
Beta Was this translation helpful? Give feedback.
-
Is this quirk up2date? |
Beta Was this translation helpful? Give feedback.
-
The Siterwell GS361A-H04 is having any clones that is using there own software ID:
From the device its some DP commands that was added and is not implanted in the tuya MCU like reporting valve position and Calibrating local temperature.
And i have found some not implanted DP that is can sending (by taking out the battery then its joined a have the quirk loaded and putting it back is sending all DP its using) that is report if the valve is jammed if valve detect is enabled, and if window detect is being triggered if window detect is enabled on the device.
List of the DPs:
0x0107 (263) Child lock switch [0], [1]
0x0112 (274) Window detect switch [0], [1]
0x0114 (276) Valve detect switch [0], [1]
0x0202 (514) Target temp
0x0203 (515) Local temp
0x0215 (533) Battery % (0-100%)
0x0404 (1028) Mode (0-3, reset mode (3) is not in GUI but can being triggered by cluster commands)
0x0411 (1041) Window open alarm (depends on 0x0112) not implanted. 0 = OK 1 = Alarm
0x0413 (1043) Valve jammed alarm (depend on 0x0114) not implanted. 0 = OK 1 = Alarm
I have updating my local quirk with deleting the 2 not existing DPs and adding valve jammed and window open alarms so they is sending to the quirk bus.
Also ZHA is using min_temp: 7 and max_temp: 30 that is lesser that the TRV is capable off so i have implanting adding it to the Zigbee side so ZHA is using the right 5-30°C and its working OK.
Now to the not implanted / fixed things:
I have looking but not fond one easy and nice way to implanting it on one Zigbee cluster but its on the list.
All modes is sent and received OK to and from the TRV but is not so nide done in ZHA then its only possible witching it on or off (off = away mode (0) and on is the last heating more used (1 or 2)).
Some other TRV have the Schedule working in ZHA but i have not found how to implanting that.
What i have not find is how to getting the TRV updating the temperature more often then every hour without changing the mode or the set point. Other TRVs is using sending calibrating local temperature and its replaying back with the "new" temperature but is not working then the device dont have DP for calibrating the temperature ;-((
Over all is one small and nice looking TRV with enough functions for "normal" users that dont need having schedule in the device and can doing it with automation in HA.
I have 2 in production and on on the table for testing for 11 mounts and one have low battery for very long time but is still on line and one have getting the valve jammed mechanically but over all they is working well.
The changes i have made is to less for putting in one PR and is not helping users but then i getting more in place i doing that but very likely is not all coming at the same time then its need finding good ways implanting it in ZHA.
Beta Was this translation helpful? Give feedback.
All reactions