Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove httparty dependency & monkey patches? #23

Open
fschwahn opened this issue Mar 2, 2016 · 0 comments
Open

Remove httparty dependency & monkey patches? #23

fschwahn opened this issue Mar 2, 2016 · 0 comments

Comments

@fschwahn
Copy link

fschwahn commented Mar 2, 2016

I'm trying to reduce the dependencies of my projects, and googl has a dependency on httparty, but uses almost no functionality of it. I replaced it with net/http in 65 LOC, and all tests remain green.

Also, I removed the monkey patches (to_openstruct and underscore) and replaced them with methods in the Googl::Utils-module.

If you are interested, I can put together PR with these changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant