Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

customize-mode compatibility #36

Open
lolbinarycat opened this issue Oct 4, 2020 · 7 comments · May be fixed by #113
Open

customize-mode compatibility #36

lolbinarycat opened this issue Oct 4, 2020 · 7 comments · May be fixed by #113

Comments

@lolbinarycat
Copy link

I typed customize-mode to add something to the hook, only to find that there wasn't one. Is there something I'm missing?

@bbuccianti
Copy link
Contributor

I think would be useful to have a hook too. Would be trivial to add one like zig-mode-hook. If folks think this is doable, I can make a PR for that.

@jcs090218
Copy link
Collaborator

zig-mode is using the standard define-derived-mode. The mode hook should be defined already. 🤔

@lolbinarycat
Copy link
Author

if i had to guess it exists but isn't visible to custom.

@jcs090218
Copy link
Collaborator

What package management tool do you use to install packages? package.el? 🤔

@lolbinarycat
Copy link
Author

yes.

it seems customize-mode is actually broken with a lot of non-core modes, i believe you need to add :group 'zig-mode to the mode definition.

@lolbinarycat lolbinarycat changed the title mode hook? customize-mode compatibility Feb 21, 2024
@jcs090218
Copy link
Collaborator

I believed is there for a long time, see

:group 'zig-mode

Apparently, customize mode can't work with unloaded module. Therefore, you have to (require 'zig-mode) before customize-mode.

ve-nt added a commit to ve-nt/zig-mode that referenced this issue Nov 1, 2024
Get zig-mode-hook to appear in the customize menu by explicitly
defining it.

This closes ziglang#36
@ve-nt ve-nt linked a pull request Nov 1, 2024 that will close this issue
@ve-nt
Copy link
Contributor

ve-nt commented Nov 1, 2024

I believed is there for a long time, see

:group 'zig-mode

Apparently, customize mode can't work with unloaded module. Therefore, you have to (require 'zig-mode) before customize-mode.

This doesn't appear to be the case on my setup. zig-mode-hook does not appear in the customize menu, despite being defined. I've created a PR (#113) that fixes this issue.

ve-nt added a commit to ve-nt/zig-mode that referenced this issue Nov 1, 2024
Get zig-mode-hook to appear in the customize menu by explicitly
defining it.

This closes ziglang#36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants