From b528767438360ad8f401257a2b635c6a017e6478 Mon Sep 17 00:00:00 2001 From: Nathan Gardet-Derc Date: Fri, 20 Sep 2024 18:57:22 +0200 Subject: [PATCH 1/2] corrected wrong link --- src/network/protocol/messages/verack.zig | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/network/protocol/messages/verack.zig b/src/network/protocol/messages/verack.zig index 5dfe3b4..47aec9f 100644 --- a/src/network/protocol/messages/verack.zig +++ b/src/network/protocol/messages/verack.zig @@ -11,7 +11,7 @@ const CompactSizeUint = @import("bitcoin-primitives").types.CompatSizeUint; /// VerackMessage represents the "verack" message /// -/// https://developer.bitcoin.org/reference/p2p_networking.html#version +/// https://developer.bitcoin.org/reference/p2p_networking.html#verack pub const VerackMessage = struct { // verack message do not contain any payload, thus there is no field @@ -42,7 +42,6 @@ pub const VerackMessage = struct { _ = self; return 0; } - }; // TESTS From 967cb17e9cdb49d3fda3536d59859438612603bb Mon Sep 17 00:00:00 2001 From: Nathan Gardet-Derc Date: Fri, 20 Sep 2024 19:04:30 +0200 Subject: [PATCH 2/2] removed "I believe" part as it's true --- src/network/wire/lib.zig | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/network/wire/lib.zig b/src/network/wire/lib.zig index 578f5c4..b690376 100644 --- a/src/network/wire/lib.zig +++ b/src/network/wire/lib.zig @@ -49,7 +49,7 @@ pub fn sendMessage(allocator: std.mem.Allocator, w: anytype, protocol_version: i defer allocator.free(payload); const checksum = computePayloadChecksum(payload); - // I believe it's safe. No payload will be longer than u32.MAX + // No payload will be longer than u32.MAX const payload_len: u32 = @intCast(payload.len); try w.writeAll(&network_id); @@ -76,10 +76,10 @@ pub fn receiveMessage(allocator: std.mem.Allocator, r: anytype) !protocol.messag const checksum = try r.readBytesNoEof(4); // Read payload - const message: protocol.messages.Message = if (std.mem.eql(u8, &command, protocol.messages.VersionMessage.name())) - protocol.messages.Message{ .Version = try protocol.messages.VersionMessage.deserializeReader(allocator, r)} + const message: protocol.messages.Message = if (std.mem.eql(u8, &command, protocol.messages.VersionMessage.name())) + protocol.messages.Message{ .Version = try protocol.messages.VersionMessage.deserializeReader(allocator, r) } else if (std.mem.eql(u8, &command, protocol.messages.VerackMessage.name())) - protocol.messages.Message{ .Verack = try protocol.messages.VerackMessage.deserializeReader(allocator, r)} + protocol.messages.Message{ .Verack = try protocol.messages.VerackMessage.deserializeReader(allocator, r) } else return error.InvalidCommand; errdefer message.deinit(allocator);