Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Partition Links #1685

Merged
merged 1 commit into from
Jan 22, 2025
Merged

Support for Partition Links #1685

merged 1 commit into from
Jan 22, 2025

Conversation

andy-maier
Copy link
Member

@andy-maier andy-maier commented Oct 5, 2024

For details, see the commit message.

The PR is ready to be merged.

@andy-maier andy-maier self-assigned this Oct 5, 2024
@andy-maier andy-maier added this to the 1.19.0 milestone Oct 5, 2024
@andy-maier andy-maier linked an issue Oct 5, 2024 that may be closed by this pull request
@andy-maier andy-maier force-pushed the andy/partition-link branch 2 times, most recently from e3498a8 to 3184b41 Compare October 24, 2024 08:24
@coveralls
Copy link
Collaborator

coveralls commented Oct 24, 2024

Coverage Status

coverage: 81.196% (-1.3%) from 82.504%
when pulling 8a92f8b on andy/partition-link
into 873a68d on master.

@andy-maier andy-maier force-pushed the andy/partition-link branch 3 times, most recently from 2a01040 to 15c7bf0 Compare October 25, 2024 15:17
@andy-maier andy-maier force-pushed the andy/partition-link branch 5 times, most recently from bb1e363 to 4b70c5f Compare January 10, 2025 13:53
@andy-maier andy-maier force-pushed the andy/partition-link branch 2 times, most recently from 5b61c6e to f775287 Compare January 10, 2025 13:56
tests/end2end/utils.py Outdated Show resolved Hide resolved
zhmcclient/_partition.py Outdated Show resolved Hide resolved
zhmcclient/_partition.py Outdated Show resolved Hide resolved
zhmcclient/_partition_link.py Outdated Show resolved Hide resolved
@andy-maier andy-maier force-pushed the andy/partition-link branch 2 times, most recently from 8c74457 to a4926fc Compare January 22, 2025 03:08
@andy-maier andy-maier changed the title [WIP] Support for Partition Links Support for Partition Links Jan 22, 2025
zhmcclient/_partition.py Outdated Show resolved Hide resolved
Details:

* Added support for Partition Links with a new 'zhmcclient.PartitionLink'
  resource class (and corresponding manager class). Added the following
  methods for partition links to the 'zhmcclient.Partition' class:
  'attach_network_link()', 'detach_network_link()',
  'attach_ctc_link()', 'detach_ctc_link()', 'list_attached_partition_links()'.

* Because the "Create Partition Link" HMC operation does not return the
  'object-uri' property of the created partition link, the handling of HTTP POST
  operations has been enhanced to add the URI returned in the "Location" header
  field as an artificial property 'location-uri' to the result data, if the
  "Location" header field is set and the result data does not contain
  'object-uri' or 'element-uri'.

* Added the following example scripts:

    examples/list_attached_partition_links.py
    examples/list_partition_links.py

* Added end2end testcases for 'zhmcclient.PartitionLink' and for the new
  methods addded to 'zhmcclient.Partition'.

* Added the following functions to the end2end utils.py:

    assert_properties(act_obj, exp_obj)
    skipif_no_partition_link_feature(cpc)
    pformat_as_dict(dict_)
    copy_dict(dict_)
    copy_list(list_)

* In the end2end utils.py function standard_partition_props(), improved
  the performance by retrieving the necessary CPC properties no longer
  by pulling all properties, but by pulling them selectively.

Signed-off-by: Andreas Maier <[email protected]>
@andy-maier andy-maier merged commit e2496a6 into master Jan 22, 2025
13 checks passed
@andy-maier andy-maier deleted the andy/partition-link branch January 22, 2025 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Partition Link resource
3 participants