Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changelog has confusingly formatted dates #500

Open
uberjay opened this issue Feb 10, 2025 · 2 comments
Open

Changelog has confusingly formatted dates #500

uberjay opened this issue Feb 10, 2025 · 2 comments
Labels
documentation Improvements or additions to documentation

Comments

@uberjay
Copy link

uberjay commented Feb 10, 2025

While tracking down what's been changed in the latest release, I noticed the dates are incorrectly formatted. As this project uses the format suggested by Keep a Changelog, it should be using ISO formatted dates -- YYYY-MM-DD. Instead, the month and day appear to be flipped.

From Keep a Changelog:

Confusing Dates

Regional date formats vary throughout the world and it's often difficult to find a human-friendly date format that feels intuitive to everyone. The advantage of dates formatted like 2017-07-17 is that they follow the order of largest to smallest units: year, month, and day. This format also doesn't overlap in ambiguous ways with other date formats, unlike some regional formats that switch the position of month and day numbers. These reasons, and the fact this date format is an ISO standard, are why it is the recommended date format for changelog entries.

@zhiburt
Copy link
Owner

zhiburt commented Feb 10, 2025

Hmmmm indeed see sometimes they got flipped but sometimes they are correct 😞
In case you have spare time you can open a PR, or I'll try to address it.

Thanks for bringing it up.

@zhiburt zhiburt added the documentation Improvements or additions to documentation label Feb 10, 2025
@zhiburt
Copy link
Owner

zhiburt commented Feb 10, 2025

According to new things:
See what's possible now 😄 ->

use tabled::Tabled;

#[derive(Tabled)]
#[tabled(display(Option, "tabled::derive::display::option", "NONE"))]
pub struct Country {
    name: String,
    capital: Option<String>,
    gdp_per_capita: Option<usize>,
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants